Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 383123003: DevTools: Do not set processId on WebDevToolsAgent explicitly now that we ask it from client. (Closed)

Created:
6 years, 5 months ago by vsevik
Modified:
6 years, 5 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Project:
chromium
Visibility:
Public.

Description

DevTools: Do not set processId on WebDevToolsAgent explicitly now that we ask it from client. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/renderer/devtools/devtools_agent.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
vsevik
PTAL
6 years, 5 months ago (2014-07-11 08:36:23 UTC) #1
pfeldman
lgtm
6 years, 5 months ago (2014-07-11 15:16:49 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 5 months ago (2014-07-14 14:36:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/383123003/1
6 years, 5 months ago (2014-07-14 14:36:51 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-14 21:20:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 22:38:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/38266)
6 years, 5 months ago (2014-07-14 22:38:35 UTC) #7
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 5 months ago (2014-07-15 12:18:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/383123003/1
6 years, 5 months ago (2014-07-15 12:20:14 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 00:22:11 UTC) #10
Message was sent while issue was closed. 
Change committed as 283299

Powered by Google App Engine
This is Rietveld 408576698