chrome/browser/background/background_application_list_model.cc - Issue 383113002: Ephemeral apps should not trigger Chrome background mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background/background_application_list_model.cc

Issue 383113002: Ephemeral apps should not trigger Chrome background mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/background/background_application_list_model_unittest.cc » ('j') | chrome/browser/background/background_application_list_model_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/background/background_application_list_model.cc

diff --git a/chrome/browser/background/background_application_list_model.cc b/chrome/browser/background/background_application_list_model.cc

index 712a2c147383460b50eb30b39036fcabc627b73c..aded46a043e63a178b5c62674b8927533a5a694a 100644

--- a/chrome/browser/background/background_application_list_model.cc

+++ b/chrome/browser/background/background_application_list_model.cc

@@ -25,6 +25,7 @@

#include "extensions/browser/extension_prefs.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_system.h"

+#include "extensions/browser/extension_util.h"

#include "extensions/browser/image_loader.h"

#include "extensions/common/extension.h"

#include "extensions/common/extension_icon_set.h"

@@ -307,6 +308,11 @@ bool BackgroundApplicationListModel::IsBackgroundApp(

// 2) It is a hosted app, and has a background contents registered or in the

// manifest.

+ // Ephemeral apps are denied any background activity after their event page

+ // has been destroyed, thus they cannot be background apps.

+ if (extensions::util::IsEphemeralApp(extension.id(), profile))

+ return false;

// Not a background app if we don't have the background permission or

// the push messaging permission

if (!extension.permissions_data()->HasAPIPermission(