Ephemeral apps should not trigger Chrome background mode

chrome/browser/background/background_mode_manager_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/background/background_mode_manager.h"
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/test_extension_system.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/status_icons/status_icon_menu_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chrome/test/base/testing_profile_manager.h"
 #include "content/public/test/test_browser_thread_bundle.h"
+#include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_system.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/image/image_unittest_util.h"
 #include "ui/message_center/message_center.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/login/users/user_manager.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
@@ skipping 229 matching lines @@
     // center during cleanup.
     message_center::MessageCenter::Shutdown();
 
     // Clear the shutdown flag to isolate the remaining effect of this test.
     browser_shutdown::SetTryingToQuit(false);
   }
 
  protected:
   scoped_ptr<SimpleTestBackgroundModeManager> manager_;
 
+  void AddEphemeralApp(const extensions::Extension* extension,
+                       ExtensionService* service) {
+    extensions::ExtensionPrefs* prefs =
+        extensions::ExtensionPrefs::Get(service->profile());
+    ASSERT_TRUE(prefs);
+    prefs->OnExtensionInstalled(extension,
+                                extensions::Extension::ENABLED,
+                                syncer::StringOrdinal(),
+                                extensions::kInstallFlagIsEphemeral,
+                                std::string());
+
+    service->AddExtension(extension);
+  }
+
  private:
   // Required for extension service.
   content::TestBrowserThreadBundle thread_bundle_;
 
 #if defined(OS_CHROMEOS)
   // ChromeOS needs extra services to run in the following order.
   chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
   chromeos::ScopedTestCrosSettings test_cros_settings_;
   chromeos::ScopedTestUserManager test_user_manager_;
 #endif
@@ skipping 530 matching lines @@
 
   scoped_refptr<extensions::Extension> upgraded_no_bg_ext_has_bg(
     CreateExtension(
         extensions::Manifest::COMMAND_LINE,
         "{\"name\": \"Regular Extension\", "
         "\"version\": \"2.0\","
         "\"manifest_version\": 2,"
         "\"permissions\": [\"background\"]}",
         "ID-2"));
 
+  scoped_refptr<extensions::Extension> ephemeral_app(
+    CreateExtension(
+        extensions::Manifest::COMMAND_LINE,
+        "{\"name\": \"Ephemeral App\", "
+        "\"version\": \"1.0\","
+        "\"manifest_version\": 2,"
+        "\"permissions\": [\"pushMessaging\"]}",
+        "ID-3"));
+
   static_cast<extensions::TestExtensionSystem*>(
       extensions::ExtensionSystem::Get(profile_))->CreateExtensionService(
           CommandLine::ForCurrentProcess(),
           base::FilePath(),
           false);
 
   ExtensionService* service =
       extensions::ExtensionSystem::Get(profile_)->extension_service();
   DCHECK(!service->is_ready());
   service->Init();
@@ skipping 12 matching lines @@
   EXPECT_FALSE(manager_->HasShownBalloon());
 
   // Upgrading an extension that has background should not reshow the balloon.
   service->AddExtension(upgraded_bg_ext);
   EXPECT_FALSE(manager_->HasShownBalloon());
 
   // Upgrading an extension that didn't have background to one that does should
   // show the balloon.
   service->AddExtension(upgraded_no_bg_ext_has_bg);
   EXPECT_TRUE(manager_->HasShownBalloon());
+
+  // Installing an ephemeral app should not show the balloon.
+  manager_->SetHasShownBalloon(false);
+  AddEphemeralApp(ephemeral_app.get(), service);
+  EXPECT_FALSE(manager_->HasShownBalloon());
+
+  // Promoting the ephemeral app to a regular installed app should now show
+  // the balloon.
+  service->PromoteEphemeralApp(ephemeral_app.get(), false /*from sync*/);
+  EXPECT_TRUE(manager_->HasShownBalloon());
 }