Ephemeral apps should not trigger Chrome background mode

chrome/browser/background/background_application_list_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/background/background_application_list_model.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/sha1.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/background/background_contents_service.h"
 #include "chrome/browser/background/background_contents_service_factory.h"
 #include "chrome/browser/background/background_mode_manager.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
+#include "extensions/browser/extension_util.h"
 #include "extensions/browser/image_loader.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_icon_set.h"
 #include "extensions/common/extension_resource.h"
 #include "extensions/common/extension_set.h"
 #include "extensions/common/manifest_handlers/background_info.h"
 #include "extensions/common/manifest_handlers/icons_handler.h"
 #include "extensions/common/permissions/permission_set.h"
 #include "extensions/common/permissions/permissions_data.h"
 #include "ui/base/l10n/l10n_util_collator.h"
@@ skipping 269 matching lines @@
   // 2) It is a hosted app, and has a background contents registered or in the
   //    manifest.
 
   // Not a background app if we don't have the background permission or
   // the push messaging permission
   if (!extension.permissions_data()->HasAPIPermission(
           APIPermission::kBackground) &&
       !RequiresBackgroundModeForPushMessaging(extension))
     return false;
 
+  // By design, ephemeral apps cannot have background activity. This point can
+  // be reached for platforms apps with the push messaging permission, so

[Dmitry Titov, 2014/07/14 03:26:35]

Also this can be reached by apps with "background' permission specified. We have
a whitelist for packaged apps that can have this permission. Also, this point
can be reached in other cases - like hosted apps with background mode.

I'd move this check to be the first and modified the comment to say something
like "nothing that is ephemeral can be background"...

[tmdiep, 2014/07/14 04:25:36]

Thanks for the suggestion. I've moved the check up and modified the comment.

We don't install the crx of hosted ephemeral apps as there is not much value in
doing so. When launched, we just navigate to their launch url in the browser. V1
apps cannot be ephemeral. So we shouldn't reach this point here for anything
other than platform apps, but it doesn't hurt to test all cases.

+  // disallow if the app is ephemeral.
+  if (extensions::util::IsEphemeralApp(extension.id(), profile))
+    return false;
+
   // Extensions and packaged apps with background permission are always treated
   // as background apps.
   if (!extension.is_hosted_app())
     return true;
 
   // Hosted apps with manifest-provided background pages are background apps.
   if (extensions::BackgroundInfo::HasBackgroundPage(&extension))
     return true;
 
   BackgroundContentsService* service =
@@ skipping 115 matching lines @@
          (*old_cursor)->name() == (*new_cursor)->name() &&
          (*old_cursor)->id() == (*new_cursor)->id()) {
     ++old_cursor;
     ++new_cursor;
   }
   if (old_cursor != extensions_.end() || new_cursor != extensions.end()) {
     extensions_ = extensions;
     FOR_EACH_OBSERVER(Observer, observers_, OnApplicationListChanged(profile_));
   }
 }