components/password_manager/core/browser/password_manager.cc - Issue 383083009: [Password Manager] Fix crash in reporting sync stats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 383083009: [Password Manager] Fix crash in reporting sync stats. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index 1cf87d2c9293bf54830d6d3e7c0ed46d869dd5a9..7ef733bc445ab61e2d52c0b56e2752c298ac6576 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -218,7 +218,7 @@ void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {

// Don't save credentials for the syncing account. See crbug.com/365832 for

// background.

- if (client_->IsPasswordSyncAccountCredential(

+ if (client_->IsSyncAccountCredential(

base::UTF16ToUTF8(form.username_value), form.signon_realm)) {

RecordFailure(SYNC_CREDENTIAL, form.origin.host(), logger.get());

return;