Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Unified Diff: chrome/browser/password_manager/sync_metrics.h

Issue 383083009: [Password Manager] Fix crash in reporting sync stats. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/sync_metrics.h
diff --git a/chrome/browser/password_manager/sync_metrics.h b/chrome/browser/password_manager/sync_metrics.h
index 5f6385f514564f09733facece760df834b32b900..2a22b07e78e7993f650be9626a8b5c34c0462a17 100644
--- a/chrome/browser/password_manager/sync_metrics.h
+++ b/chrome/browser/password_manager/sync_metrics.h
@@ -12,14 +12,16 @@ class Profile;
namespace password_manager_sync_metrics {
// Returns the sync username for |profile|. Returns an empty string if the
-// |profile| isn't syncing passwords.
-std::string GetPasswordSyncUsername(Profile* profile);
+// |profile| isn't syncing. It would be preferable to only return the username
+// if the user is syncing passwords, but that is not currently possible since
+// this function can be called during sync setup (http://crbug.com/393626).
+std::string GetSyncUsername(Profile* profile);
// Returns true if |username| and |origin| correspond to the account which is
-// syncing passwords. Will return false if |profile| is not syncing passwords.
-bool IsPasswordSyncAccountCredential(Profile* profile,
- const std::string& username,
- const std::string& origin);
+// syncing. Will return false if |profile| is not syncing.
+bool IsSyncAccountCredential(Profile* profile,
+ const std::string& username,
+ const std::string& origin);
} // namespace password_manager_sync_metrics
« no previous file with comments | « chrome/browser/password_manager/password_store_factory.cc ('k') | chrome/browser/password_manager/sync_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698