[Password Manager] Fix crash in reporting sync stats.

chrome/browser/password_manager/sync_metrics.h

Index: chrome/browser/password_manager/sync_metrics.h
diff --git a/chrome/browser/password_manager/sync_metrics.h b/chrome/browser/password_manager/sync_metrics.h
index 5f6385f514564f09733facece760df834b32b900..e49a8ff6f20d2310d0648fa359291c8bdb2c4d33 100644
--- a/chrome/browser/password_manager/sync_metrics.h
+++ b/chrome/browser/password_manager/sync_metrics.h
@@ -12,14 +12,16 @@ class Profile;
 namespace password_manager_sync_metrics {
 
 // Returns the sync username for |profile|. Returns an empty string if the
-// |profile| isn't syncing passwords.
-std::string GetPasswordSyncUsername(Profile* profile);
+// |profile| isn't syncing. It would be preferable to only return the username
+// if the user is syncing passwords, but that is not currently possible since
+// this function can be called during sync setup (crbug.com/393626).

[Ilya Sherman, 2014/07/15 01:09:11]

I'm pretty sure it's possible to check whether Sync is currently being set up or
not.  Would you be happy if the metric simply weren't emitted during Sync setup?

[Ilya Sherman, 2014/07/15 01:09:11]

nit: Please prepend "http://" to the link to increase likelihood of
autolinkification.

[Garrett Casto, 2014/07/15 05:39:03]

Currently moving offices, so I'll get this when my computer is hooked up
tomorrow.

[Garrett Casto, 2014/07/15 05:39:03]

I haven't tested this yet, but I'm guessing it's pretty likely to guaranteed
that if you are syncing the first PasswordStoreFactory::GetForProfile() call is
going to happen because of sync. Even if it's more random than that, if we did
something like that it seems like we would want to have different histograms
based on if the username was for password sync or just sync. Just seems cleaner
this way.

+std::string GetSyncUsername(Profile* profile);
 
 // Returns true if |username| and |origin| correspond to the account which is
-// syncing passwords. Will return false if |profile| is not syncing passwords.
-bool IsPasswordSyncAccountCredential(Profile* profile,
-                                     const std::string& username,
-                                     const std::string& origin);
+// syncing. Will return false if |profile| is not syncing.
+bool IsSyncAccountCredential(Profile* profile,
+                             const std::string& username,
+                             const std::string& origin);
 
 }  // namespace password_manager_sync_metrics