Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: trunk/src/content/browser/media/media_browsertest.h

Issue 383063009: Revert 282795 "Have media content and chrome browser tests load ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/media/media_browsertest.h
===================================================================
--- trunk/src/content/browser/media/media_browsertest.h (revision 282811)
+++ trunk/src/content/browser/media/media_browsertest.h (working copy)
@@ -5,10 +5,10 @@
#ifndef CONTENT_BROWSER_MEDIA_MEDIA_BROWSERTEST_H_
#define CONTENT_BROWSER_MEDIA_MEDIA_BROWSERTEST_H_
-#include <string>
+#include <utility>
+#include <vector>
#include "content/public/test/content_browser_test.h"
-#include "media/base/test_data_util.h"
namespace content {
@@ -19,6 +19,8 @@
// the test http server.
class MediaBrowserTest : public ContentBrowserTest {
public:
+ typedef std::pair<const char*, const char*> StringPair;
+
// Common test results.
static const char kEnded[];
static const char kError[];
@@ -28,18 +30,17 @@
// If http is true, the test starts a local http test server to load the test
// page, otherwise a local file URL is loaded inside the content shell.
// It uses RunTest() to check for expected test output.
- void RunMediaTestPage(const std::string& html_page,
- const media::QueryParams& query_params,
- const std::string& expected,
- bool http);
+ void RunMediaTestPage(const char* html_page,
+ std::vector<StringPair>* query_params,
+ const char* expected, bool http);
// Opens a URL and waits for the document title to match either one of the
- // default strings or the expected string. Returns the matching title value.
- std::string RunTest(const GURL& gurl, const std::string& expected);
+ // default strings or the expected string.
+ void RunTest(const GURL& gurl, const char* expected);
virtual void AddWaitForTitles(content::TitleWatcher* title_watcher);
};
-} // namespace content
+} // namespace content
#endif // CONTENT_BROWSER_MEDIA_MEDIA_BROWSERTEST_H_
« no previous file with comments | « trunk/src/content/browser/media/encrypted_media_browsertest.cc ('k') | trunk/src/content/browser/media/media_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698