Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 383063009: Revert 282795 "Have media content and chrome browser tests load ..." (Closed)

Created:
6 years, 5 months ago by shadi
Modified:
6 years, 5 months ago
Reviewers:
shadi
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 282795 "Have media content and chrome browser tests load ..." It broke browser tests. Probably need to update isolate files to fix it... > Have media content and chrome browser tests load data from media/test/data > > With media files copied over to media/test/data, this CL makes media related content browser tests and chrome browser tests load test data from one location. > > The location is common with media unit tests data forder; managed in one place in media/base/test_data_util.h > > BUG=379314 > > Review URL: https://codereview.chromium.org/357413002 TBR=shadi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282812

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -1822 lines) Patch
M trunk/src/chrome/browser/media/encrypted_media_browsertest.cc View 14 chunks +28 lines, -31 lines 0 comments Download
M trunk/src/chrome/browser/media/encrypted_media_istypesupported_browsertest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/media/media_browsertest.h View 3 chunks +8 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/media/media_browsertest.cc View 3 chunks +30 lines, -17 lines 0 comments Download
A + trunk/src/chrome/test/data/media/eme_player.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/eme_player_js/app_loader.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/eme_player_js/clearkey_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/eme_player_js/eme_app.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/eme_player_js/file_io_test_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/eme_player_js/fps_observer.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/eme_player_js/globals.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/eme_player_js/media_source_utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/eme_player_js/player_utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/eme_player_js/prefixed_clearkey_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/eme_player_js/prefixed_widevine_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/eme_player_js/test_config.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/eme_player_js/utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/eme_player_js/widevine_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/encrypted_frame_size_change.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/frame_size_change-av-enc-v.webm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/mse_config_change.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/test/data/media/test_key_system_instantiation.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/browser/media/encrypted_media_browsertest.cc View 7 chunks +31 lines, -40 lines 0 comments Download
M trunk/src/content/browser/media/media_browsertest.h View 3 chunks +10 lines, -9 lines 0 comments Download
M trunk/src/content/browser/media/media_browsertest.cc View 7 chunks +46 lines, -43 lines 0 comments Download
M trunk/src/content/browser/media/media_source_browsertest.cc View 2 chunks +7 lines, -11 lines 0 comments Download
A + trunk/src/content/test/data/media/blackwhite.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/test/data/media/encrypted_frame_size_change.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/test/data/media/encrypted_media_player.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/test/data/media/encrypted_media_utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/test/data/media/media_source_player.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/test/data/media/media_source_utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/test/data/media/media_utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/test/data/media/mse_config_change.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/content/test/data/media/player.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/media/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/media/base/test_data_util.h View 1 chunk +0 lines, -15 lines 0 comments Download
M trunk/src/media/base/test_data_util.cc View 1 chunk +4 lines, -28 lines 0 comments Download
M trunk/src/media/media.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/media/test/data/blackwhite.html View 1 chunk +0 lines, -231 lines 0 comments Download
D trunk/src/media/test/data/eme_player.html View 1 chunk +0 lines, -108 lines 0 comments Download
D trunk/src/media/test/data/eme_player_js/app_loader.js View 1 chunk +0 lines, -24 lines 0 comments Download
D trunk/src/media/test/data/eme_player_js/clearkey_player.js View 1 chunk +0 lines, -33 lines 0 comments Download
D trunk/src/media/test/data/eme_player_js/eme_app.js View 1 chunk +0 lines, -81 lines 0 comments Download
D trunk/src/media/test/data/eme_player_js/file_io_test_player.js View 1 chunk +0 lines, -34 lines 0 comments Download
D trunk/src/media/test/data/eme_player_js/fps_observer.js View 1 chunk +0 lines, -67 lines 0 comments Download
D trunk/src/media/test/data/eme_player_js/globals.js View 1 chunk +0 lines, -80 lines 0 comments Download
D trunk/src/media/test/data/eme_player_js/media_source_utils.js View 1 chunk +0 lines, -70 lines 0 comments Download
D trunk/src/media/test/data/eme_player_js/player_utils.js View 1 chunk +0 lines, -186 lines 0 comments Download
D trunk/src/media/test/data/eme_player_js/prefixed_clearkey_player.js View 1 chunk +0 lines, -27 lines 0 comments Download
D trunk/src/media/test/data/eme_player_js/prefixed_widevine_player.js View 1 chunk +0 lines, -32 lines 0 comments Download
D trunk/src/media/test/data/eme_player_js/test_config.js View 1 chunk +0 lines, -65 lines 0 comments Download
D trunk/src/media/test/data/eme_player_js/utils.js View 1 chunk +0 lines, -245 lines 0 comments Download
D trunk/src/media/test/data/eme_player_js/widevine_player.js View 1 chunk +0 lines, -38 lines 0 comments Download
D trunk/src/media/test/data/encrypted_frame_size_change.html View 1 chunk +0 lines, -50 lines 0 comments Download
D trunk/src/media/test/data/media_source_player.html View 1 chunk +0 lines, -38 lines 0 comments Download
D trunk/src/media/test/data/mse_config_change.html View 1 chunk +0 lines, -134 lines 0 comments Download
D trunk/src/media/test/data/player.html View 1 chunk +0 lines, -77 lines 0 comments Download
D trunk/src/media/test/data/test_key_system_instantiation.html View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
shadi
6 years, 5 months ago (2014-07-12 07:31:55 UTC) #1
shadi
6 years, 5 months ago (2014-07-12 07:36:33 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r282812 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698