Source/web/WebEmbeddedWorkerImpl.cpp - Issue 383063008: Expose the ServiceWorker's v8 context to embedders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebEmbeddedWorkerImpl.cpp

Issue 383063008: Expose the ServiceWorker's v8 context to embedders. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@pinned

Patch Set: Remove an unused v8::Isolate forward decl (but should the Proxy expose an Isolate?) Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/web/ServiceWorkerGlobalScopeProxy.h ('K') | « Source/web/WebEmbeddedWorkerImpl.h ('k') | Source/web/tests/ServiceWorkerGlobalScopeProxyTest.cpp » ('j') | Source/web/tests/ServiceWorkerGlobalScopeProxyTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/WebEmbeddedWorkerImpl.cpp

diff --git a/Source/web/WebEmbeddedWorkerImpl.cpp b/Source/web/WebEmbeddedWorkerImpl.cpp

index 3c396de4c8341f4259073035c84d9491fdf29fff..a5d085e8834c6638966c17642cf42089190abc81 100644

--- a/Source/web/WebEmbeddedWorkerImpl.cpp

+++ b/Source/web/WebEmbeddedWorkerImpl.cpp

@@ -169,6 +169,12 @@ WebEmbeddedWorkerImpl::~WebEmbeddedWorkerImpl()

m_mainFrame->close();

}

+void WebEmbeddedWorkerImpl::postTask(PassOwnPtr<ExecutionContextTask> task)

+ // We don't propagate the bool return because |true| doesn't mean the task will be run.

+ m_workerThread->runLoop().postTask(task);

void WebEmbeddedWorkerImpl::startWorkerContext(

const WebEmbeddedWorkerStartData& data)

{