Make SkPDFFont::fFontInfo a const pointer.

Make SkPDFFont::fFontInfo a const pointer.

BUG=skia:2742
Committed: https://skia.googlesource.com/skia/+/fb747e2c745896dd94425ff690483ae3838e88fe

[hal.canary, 2014-07-11 21:02:23]

ptal

[scroggo, 2014-07-11 21:17:34]

On 2014/07/11 21:02:23, Hal Canary wrote:
> ptal

Does this fix the bug? I don't see any removal of code that was modifying the
SkAdvancedTypefaceMetrics object. Should the SkAdvancedTypefaceMetrics class
itself be immutable, or in other cases do we want to modify it?

[hal.canary, 2014-07-11 21:21:28]

On 2014/07/11 21:17:34, scroggo wrote:
> On 2014/07/11 21:02:23, Hal Canary wrote:
> > ptal
> 
> Does this fix the bug? I don't see any removal of code that was modifying the
> SkAdvancedTypefaceMetrics object. Should the SkAdvancedTypefaceMetrics class
> itself be immutable, or in other cases do we want to modify it?

It does not fix anything, and should produce identical machine code.  I just
wrote this to verify that PDF code isn't changing the SkAdvancedTypefaceMetrics
values, which means the problem lies somewhere else.

[scroggo, 2014-07-11 21:22:55]

lgtm

[hal.canary, 2014-07-11 23:40:03]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-07-11 23:41:10]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/halcanary@google.com/383063007/1

[commit-bot: I haz the power, 2014-07-12 02:45:28]

Change committed as fb747e2c745896dd94425ff690483ae3838e88fe