Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issue 38303003: Try again to deflake animations/play-state.html (Closed)

Created:
7 years, 1 month ago by Steve Block
Modified:
7 years, 1 month ago
Reviewers:
dstockwell
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Try again to deflake animations/play-state.html Currently, we use runAnimationTest(), but this can't use the pause API because it's incompatible with pausing animations through CSS. As a result, it's flaky. This change re-writes the test to not use runAnimationTest() and to avoid the need for precise timing, R=dstockwell Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160403

Patch Set 1 #

Total comments: 2

Patch Set 2 : Increase delay before testing end state #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -55 lines) Patch
M LayoutTests/animations/play-state.html View 1 1 chunk +66 lines, -46 lines 0 comments Download
M LayoutTests/animations/play-state-expected.txt View 1 chunk +7 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Steve Block
7 years, 1 month ago (2013-10-24 00:26:22 UTC) #1
dstockwell
lgtm https://codereview.chromium.org/38303003/diff/1/LayoutTests/animations/play-state.html File LayoutTests/animations/play-state.html (right): https://codereview.chromium.org/38303003/diff/1/LayoutTests/animations/play-state.html#newcode75 LayoutTests/animations/play-state.html:75: setTimeout(end, 60); 60 is still quite short, should ...
7 years, 1 month ago (2013-10-24 00:35:02 UTC) #2
Steve Block
https://codereview.chromium.org/38303003/diff/1/LayoutTests/animations/play-state.html File LayoutTests/animations/play-state.html (right): https://codereview.chromium.org/38303003/diff/1/LayoutTests/animations/play-state.html#newcode75 LayoutTests/animations/play-state.html:75: setTimeout(end, 60); Using the end event actually makes it ...
7 years, 1 month ago (2013-10-24 00:41:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/38303003/20001
7 years, 1 month ago (2013-10-24 00:43:48 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-24 01:37:44 UTC) #5
Message was sent while issue was closed.
Change committed as 160403

Powered by Google App Engine
This is Rietveld 408576698