mojo/DEPS - Issue 38303002: Enable Mojo to download from file URLs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/DEPS

Issue 38303002: Enable Mojo to download from file URLs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove unneeded include Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+base",	2 "+base",

3 "+build",	3 "+build",

4 "+mojo",	4 "+mojo",

	5 "+net",
	darin (slow to review) 2013/10/24 06:13:25 Adam said he was trying to hide the net dependency Adam said he was trying to hide the net dependency inside the mojo/loader/ directory. I should have also added a comment in this DEPS file saying that anything you add here you have to consider subtracting from mojo/public/DEPS :-P abarth-chromium 2013/10/24 16:25:23 LGTM if you move this +net line into mojo/shell/DE LGTM if you move this +net line into mojo/shell/DEPS so that it doesn't leak into mojo/public. If you do decide to introduce the net dependency to mojo/shell, we should just move all the files from mojo/loader into mojo/shell and worry about sorting them out later. We can move the files around in a separate CL. Aaron Boodman 2013/10/25 21:19:50 As we discussed, I moved the net include rule down Show quoted text On 2013/10/24 16:25:23, abarth wrote: > LGTM if you move this +net line into mojo/shell/DEPS so that it doesn't leak > into mojo/public. > > If you do decide to introduce the net dependency to mojo/shell, we should just > move all the files from mojo/loader into mojo/shell and worry about sorting them > out later. We can move the files around in a separate CL. As we discussed, I moved the net include rule down into mojo/shell. A future change will move loader into shell.
5 "+testing",	6 "+testing",

6 ]	7 ]

OLD	NEW

« no previous file with comments | « no previous file | mojo/loader/DEPS » ('j') | no next file with comments »