Enable Mojo to download from file URLs

net/base/network_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/network_delegate.h"
 
 #include "base/logging.h"
 #include "net/base/load_flags.h"
+#include "net/base/net_errors.h"
 #include "net/url_request/url_request.h"
 
 namespace net {
 
 int NetworkDelegate::NotifyBeforeURLRequest(
     URLRequest* request, const CompletionCallback& callback,
     GURL* new_url) {
   DCHECK(CalledOnValidThread());
   DCHECK(request);
   DCHECK(!callback.is_null());
@@ skipping 99 matching lines @@
   return OnCanThrottleRequest(request);
 }
 
 bool NetworkDelegate::CanEnablePrivacyMode(
     const GURL& url,
     const GURL& first_party_for_cookies) const {
   DCHECK(CalledOnValidThread());
   return OnCanEnablePrivacyMode(url, first_party_for_cookies);
 }
 
+int NetworkDelegate::OnBeforeURLRequest(URLRequest* request,
+                                        const CompletionCallback& callback,
+                                        GURL* new_url) {
+  return net::OK;

[willchan no longer on Chromium, 2013/10/24 22:03:36]

no need for net:: prefix everywhere here, since it's already in the net
namescape

[Aaron Boodman, 2013/10/25 21:19:50]

Done.

+}
+
+int NetworkDelegate::OnBeforeSendHeaders(URLRequest* request,
+                                         const CompletionCallback& callback,
+                                         HttpRequestHeaders* headers) {
+  return net::OK;
+}
+
+void NetworkDelegate::OnSendHeaders(URLRequest* request,
+                                    const HttpRequestHeaders& headers) {
+}
+
+int NetworkDelegate::OnHeadersReceived(
+    URLRequest* request,
+    const CompletionCallback& callback,
+    const HttpResponseHeaders* original_response_headers,
+    scoped_refptr<HttpResponseHeaders>* override_response_headers) {
+  return net::OK;
+}
+
+void NetworkDelegate::OnBeforeRedirect(URLRequest* request,
+                                       const GURL& new_location) {
+}
+
+void NetworkDelegate::OnResponseStarted(URLRequest* request) {
+}
+
+void NetworkDelegate::OnRawBytesRead(const URLRequest& request,
+                                     int bytes_read) {
+}
+
+void NetworkDelegate::OnCompleted(URLRequest* request, bool started) {
+}
+
+void NetworkDelegate::OnURLRequestDestroyed(URLRequest* request) {
+}
+
+void NetworkDelegate::OnPACScriptError(int line_number,
+                                       const base::string16& error) {
+}
+
+NetworkDelegate::AuthRequiredResponse NetworkDelegate::OnAuthRequired(
+    URLRequest* request,
+    const AuthChallengeInfo& auth_info,
+    const AuthCallback& callback,
+    AuthCredentials* credentials) {
+  return AUTH_REQUIRED_RESPONSE_NO_ACTION;
+}
+
+bool NetworkDelegate::OnCanGetCookies(const URLRequest& request,
+                                      const CookieList& cookie_list)  {
+  return true;
+}
+
+bool NetworkDelegate::OnCanSetCookie(const URLRequest& request,
+                                     const std::string& cookie_line,
+                                     CookieOptions* options) {
+  return true;
+}
+
+bool NetworkDelegate::OnCanAccessFile(const URLRequest& request,
+                                      const base::FilePath& path) const  {
+  return false;
+}
+
+bool NetworkDelegate::OnCanThrottleRequest(const URLRequest& request) const {
+  return false;
+}
+
 bool NetworkDelegate::OnCanEnablePrivacyMode(
     const GURL& url,
     const GURL& first_party_for_cookies) const {
-  // Default implementation disables privacy mode.
   return false;
 }
 
+int NetworkDelegate::OnBeforeSocketStreamConnect(
+    SocketStream* socket,
+    const CompletionCallback& callback) {
+  return net::OK;
+}
+
+void NetworkDelegate::OnRequestWaitStateChange(const URLRequest& request,
+                                               RequestWaitState state) {
+}
+
 int NetworkDelegate::NotifyBeforeSocketStreamConnect(
     SocketStream* socket,
     const CompletionCallback& callback) {
   DCHECK(CalledOnValidThread());
   DCHECK(socket);
   DCHECK(!callback.is_null());
   return OnBeforeSocketStreamConnect(socket, callback);
 }
 
 void NetworkDelegate::NotifyRequestWaitStateChange(const URLRequest& request,

[mmenke, 2013/10/25 17:59:14]

These should be up with the other notify functions, please move them (Know that
they were incorrectly below OnCanEnablePrivacyMode before, but think it's a
minor enough cleanup that including it in this CL is fine).

[Aaron Boodman, 2013/10/25 21:21:42]

Done.

                                                    RequestWaitState state) {
   DCHECK(CalledOnValidThread());
   OnRequestWaitStateChange(request, state);
 }
 
 }  // namespace net