Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 383023002: Partial setup flow with unittest. (Closed)

Created:
6 years, 5 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 5 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Partial setup flow with unittest. BUG=372843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283866

Patch Set 1 #

Patch Set 2 : Thu 07/10/2014 17:43:26.43 #

Patch Set 3 : #

Patch Set 4 : Wed 07/16/2014 12:37:42.65 #

Total comments: 4

Patch Set 5 : Wed 07/16/2014 15:23:11.20 #

Patch Set 6 : Wed 07/16/2014 18:14:14.31 #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+532 lines, -17 lines) Patch
M chrome/browser/local_discovery/privet_constants.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_constants.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_url_fetcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/local_discovery/privetv3_session.h View 1 2 3 4 5 6 4 chunks +23 lines, -13 lines 0 comments Download
M chrome/browser/local_discovery/privetv3_session.cc View 1 2 3 4 5 6 7 1 chunk +100 lines, -1 line 0 comments Download
A chrome/browser/local_discovery/privetv3_session_unittest.cc View 1 2 3 4 1 chunk +59 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privetv3_setup_flow.h View 1 2 3 4 3 chunks +19 lines, -2 lines 0 comments Download
M chrome/browser/local_discovery/privetv3_setup_flow.cc View 1 2 3 4 3 chunks +135 lines, -1 line 0 comments Download
A chrome/browser/local_discovery/privetv3_setup_flow_unittest.cc View 1 2 3 4 5 1 chunk +185 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 5 months ago (2014-07-11 21:35:54 UTC) #1
Noam Samuel
https://codereview.chromium.org/383023002/diff/60001/chrome/browser/local_discovery/privetv3_session.cc File chrome/browser/local_discovery/privetv3_session.cc (right): https://codereview.chromium.org/383023002/diff/60001/chrome/browser/local_discovery/privetv3_session.cc#newcode61 chrome/browser/local_discovery/privetv3_session.cc:61: request->url_fetcher_->SendEmptyPrivetToken(); Please remove this line. https://codereview.chromium.org/383023002/diff/60001/chrome/browser/local_discovery/privetv3_setup_flow.h File chrome/browser/local_discovery/privetv3_setup_flow.h (right): ...
6 years, 5 months ago (2014-07-16 20:48:24 UTC) #2
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/383023002/diff/60001/chrome/browser/local_discovery/privetv3_session.cc File chrome/browser/local_discovery/privetv3_session.cc (right): https://codereview.chromium.org/383023002/diff/60001/chrome/browser/local_discovery/privetv3_session.cc#newcode61 chrome/browser/local_discovery/privetv3_session.cc:61: request->url_fetcher_->SendEmptyPrivetToken(); On 2014/07/16 20:48:23, Noam Samuel wrote: > Please ...
6 years, 5 months ago (2014-07-16 20:53:23 UTC) #3
Noam Samuel
lgtm
6 years, 5 months ago (2014-07-16 20:57:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/383023002/60001
6 years, 5 months ago (2014-07-16 20:59:13 UTC) #5
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 5 months ago (2014-07-16 20:59:35 UTC) #6
Vitaly Buka (NO REVIEWS)
On 2014/07/16 20:59:13, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 5 months ago (2014-07-16 21:01:24 UTC) #7
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 5 months ago (2014-07-16 22:22:40 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 5 months ago (2014-07-16 22:23:18 UTC) #9
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 5 months ago (2014-07-16 22:24:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/383023002/140001
6 years, 5 months ago (2014-07-16 22:29:39 UTC) #11
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 5 months ago (2014-07-17 01:16:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/383023002/180001
6 years, 5 months ago (2014-07-17 01:18:11 UTC) #13
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 5 months ago (2014-07-17 06:08:10 UTC) #14
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 5 months ago (2014-07-17 07:19:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/383023002/200001
6 years, 5 months ago (2014-07-17 07:22:32 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 11:34:05 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 13:13:54 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/26709)
6 years, 5 months ago (2014-07-17 13:13:55 UTC) #19
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 5 months ago (2014-07-17 16:35:26 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/383023002/220001
6 years, 5 months ago (2014-07-17 16:38:29 UTC) #21
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 20:52:17 UTC) #22
Message was sent while issue was closed. 
Change committed as 283866

Powered by Google App Engine
This is Rietveld 408576698