Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 383012: Fix for issue 27210, show bookmarks bar menu is out of sync with the browser's status. (Closed)

Created:
11 years, 1 month ago by oshima
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix for issue 27210, show bookmarks bar menu is out of sync with the browser's status. * Update the states of menu before showing menu like Window's menu does. * Don't fire activate signal when the state is chagned via API. * Eliminated UpdateStateData and replace it with the NativeMenuGtk and the position stored in the gtk widget. * Fixed StateAreaView to check bookmark bar status. BUG=27210 TEST=Run linux builds (gtk/views/chromeos) check if the bookmark bar menu's status is in sync with the bookmark bar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31654

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -27 lines) Patch
M chrome/browser/chromeos/status_area_view.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M views/controls/menu/native_menu_gtk.h View 2 chunks +10 lines, -2 lines 0 comments Download
M views/controls/menu/native_menu_gtk.cc View 8 chunks +28 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
11 years, 1 month ago (2009-11-11 01:10:38 UTC) #1
oshima
Reviewers: Ben Goodger, Description: Fix for issue 27210, show bookmarks bar menu is out of ...
11 years, 1 month ago (2009-11-11 01:11:01 UTC) #2
Ben Goodger (Google)
OK
11 years, 1 month ago (2009-11-11 01:49:59 UTC) #3
Ben Goodger (Google)
11 years, 1 month ago (2009-11-11 01:50:17 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698