Issue 383004: A quick fix for Issue 26880....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 383004: A quick fix for Issue 26880.... (Closed)

Created:
11 years, 1 month ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, pam+watch_chromium.org, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A quick fix for Issue 26880. As Firefox does, we need to use Carbon APIs to finish an ongoing composition because Leopard does not have Cocoa API [NSTextInputContext discardMarkedText:]. I'm wondering if this code can be compiled on Snow Leopard having xcode 4.2 installed, this change enclose this Carbon call with #ifdef and #endif. BUG=26880 TEST=Enable a Chinese IME, type "baobao", click outside from the candidate window, and check if the candidate window is closed.

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -22 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View		4 chunks	+33 lines, -22 lines	0 comments	Download