Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 383003002: Pass the client certificate into OpenSSL in common code. (Closed)

Created:
6 years, 5 months ago by davidben
Modified:
6 years, 5 months ago
Reviewers:
Mark P, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Pass the client certificate into OpenSSL in common code. The private key's the hard one, but this is a first step and can be independent of USE_OPENSSL_CERTS. BUG=362035 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282770

Patch Set 1 #

Patch Set 2 : Fix build #

Patch Set 3 : Split out ScopedEVP_PKEY change #

Total comments: 3

Patch Set 4 : #

Total comments: 2

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -16 lines) Patch
M net/base/net_error_list.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 2 3 4 3 chunks +40 lines, -16 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
davidben
https://codereview.chromium.org/383003002/diff/40001/net/socket/ssl_client_socket_openssl.cc File net/socket/ssl_client_socket_openssl.cc (right): https://codereview.chromium.org/383003002/diff/40001/net/socket/ssl_client_socket_openssl.cc#newcode1373 net/socket/ssl_client_socket_openssl.cc:1373: OpenSSLClientKeyStore::ScopedEVP_PKEY privkey; This silly thing will be crypto::ScopedEVP_PKEY with ...
6 years, 5 months ago (2014-07-11 00:10:26 UTC) #1
Ryan Sleevi
https://codereview.chromium.org/383003002/diff/40001/crypto/scoped_openssl_types.h File crypto/scoped_openssl_types.h (right): https://codereview.chromium.org/383003002/diff/40001/crypto/scoped_openssl_types.h#newcode47 crypto/scoped_openssl_types.h:47: typedef ScopedOpenSSL<X509, X509_free>::Type ScopedX509; Please read the comments on ...
6 years, 5 months ago (2014-07-11 01:06:23 UTC) #2
davidben
https://codereview.chromium.org/383003002/diff/40001/crypto/scoped_openssl_types.h File crypto/scoped_openssl_types.h (right): https://codereview.chromium.org/383003002/diff/40001/crypto/scoped_openssl_types.h#newcode47 crypto/scoped_openssl_types.h:47: typedef ScopedOpenSSL<X509, X509_free>::Type ScopedX509; On 2014/07/11 01:06:23, Ryan Sleevi ...
6 years, 5 months ago (2014-07-11 13:47:16 UTC) #3
Ryan Sleevi
lgtm https://codereview.chromium.org/383003002/diff/60001/net/socket/ssl_client_socket_openssl.cc File net/socket/ssl_client_socket_openssl.cc (right): https://codereview.chromium.org/383003002/diff/60001/net/socket/ssl_client_socket_openssl.cc#newcode1372 net/socket/ssl_client_socket_openssl.cc:1372: OpenSSLPutNetError(FROM_HERE, ERR_SSL_CLIENT_AUTH_CERT_BAD_FORMAT); Update NSS to use this code ...
6 years, 5 months ago (2014-07-11 18:20:14 UTC) #4
davidben
Holding on landing this until https://codereview.chromium.org/388683002/ goes through since it'll need a (trivial) rebase. https://codereview.chromium.org/383003002/diff/60001/net/socket/ssl_client_socket_openssl.cc ...
6 years, 5 months ago (2014-07-11 18:32:20 UTC) #5
davidben
+mpearson for histograms.xml
6 years, 5 months ago (2014-07-11 20:45:43 UTC) #6
Mark P
lgtm
6 years, 5 months ago (2014-07-11 21:12:18 UTC) #7
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 5 months ago (2014-07-11 21:29:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/383003002/80001
6 years, 5 months ago (2014-07-11 21:30:48 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 01:25:19 UTC) #10
Message was sent while issue was closed. 
Change committed as 282770

Powered by Google App Engine
This is Rietveld 408576698