Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 382963003: fix sizing of inputs in search engine manager (Closed)

Created:
6 years, 5 months ago by Evan Stade
Modified:
6 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

fix sizing of inputs in search engine manager BUG=392874 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282494

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/options/search_engine_manager.css View 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Evan Stade
6 years, 5 months ago (2014-07-10 21:11:12 UTC) #1
Dan Beam
lgtm https://codereview.chromium.org/382963003/diff/1/chrome/browser/resources/options/search_engine_manager.css File chrome/browser/resources/options/search_engine_manager.css (right): https://codereview.chromium.org/382963003/diff/1/chrome/browser/resources/options/search_engine_manager.css#newcode71 chrome/browser/resources/options/search_engine_manager.css:71: -webkit-margin-start: 1ex; nit: did you mean em?
6 years, 5 months ago (2014-07-10 22:28:54 UTC) #2
Evan Stade
https://codereview.chromium.org/382963003/diff/1/chrome/browser/resources/options/search_engine_manager.css File chrome/browser/resources/options/search_engine_manager.css (right): https://codereview.chromium.org/382963003/diff/1/chrome/browser/resources/options/search_engine_manager.css#newcode71 chrome/browser/resources/options/search_engine_manager.css:71: -webkit-margin-start: 1ex; On 2014/07/10 22:28:54, Dan Beam wrote: > ...
6 years, 5 months ago (2014-07-10 22:50:32 UTC) #3
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-10 22:50:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/382963003/1
6 years, 5 months ago (2014-07-10 22:51:53 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 01:37:30 UTC) #6
Message was sent while issue was closed.
Change committed as 282494

Powered by Google App Engine
This is Rietveld 408576698