Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 382943003: GN: Build file for component/auto_login_parser (Closed)

Created:
6 years, 5 months ago by Alpha Left Google
Modified:
6 years, 5 months ago
CC:
chromium-reviews, awong
Project:
chromium
Visibility:
Public.

Description

GN: Build file for component/auto_login_parser Adding component/auto_login_parser/BUILD.gn. TBR=jochen Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283533

Patch Set 1 #

Patch Set 2 : done #

Total comments: 1

Patch Set 3 : reordered #

Patch Set 4 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M components/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A components/auto_login_parser/BUILD.gn View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (0 generated)
Alpha Left Google
6 years, 5 months ago (2014-07-10 20:40:42 UTC) #1
Alpha Left Google
6 years, 5 months ago (2014-07-10 20:50:25 UTC) #2
Alpha Left Google
CC ajwong.
6 years, 5 months ago (2014-07-10 21:01:35 UTC) #3
awong
LGTM, but please reupload with --no-find-copies.
6 years, 5 months ago (2014-07-10 22:42:39 UTC) #4
Alpha Left Google
Done. And +boliu for OWNERS approval.
6 years, 5 months ago (2014-07-11 18:10:34 UTC) #5
brettw
lgtm https://codereview.chromium.org/382943003/diff/20001/components/auto_login_parser/BUILD.gn File components/auto_login_parser/BUILD.gn (right): https://codereview.chromium.org/382943003/diff/20001/components/auto_login_parser/BUILD.gn#newcode11 components/auto_login_parser/BUILD.gn:11: sources = [ Put this first, deps second.
6 years, 5 months ago (2014-07-11 20:09:10 UTC) #6
Alpha Left Google
+boliu for owners approval.
6 years, 5 months ago (2014-07-14 18:14:32 UTC) #7
boliu
lgtm
6 years, 5 months ago (2014-07-14 18:15:47 UTC) #8
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 5 months ago (2014-07-14 18:20:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/382943003/40001
6 years, 5 months ago (2014-07-14 18:22:22 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-14 18:35:45 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 18:37:57 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/170021) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/159057) ios_rel_device_ninja ...
6 years, 5 months ago (2014-07-14 18:37:58 UTC) #13
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 5 months ago (2014-07-14 19:55:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/382943003/60001
6 years, 5 months ago (2014-07-14 19:57:55 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-14 21:59:29 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 22:02:11 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79855)
6 years, 5 months ago (2014-07-14 22:02:12 UTC) #18
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 5 months ago (2014-07-15 23:41:38 UTC) #19
Alpha Left Google
+jochen for approval of component/
6 years, 5 months ago (2014-07-15 23:43:46 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/382943003/60001
6 years, 5 months ago (2014-07-15 23:44:44 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 00:25:48 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 00:33:46 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/80140)
6 years, 5 months ago (2014-07-16 00:33:47 UTC) #24
Alpha Left Google
+ blundell for owner approval.
6 years, 5 months ago (2014-07-16 18:18:29 UTC) #25
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 5 months ago (2014-07-16 21:46:10 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/382943003/60001
6 years, 5 months ago (2014-07-16 21:48:47 UTC) #27
commit-bot: I haz the power
Change committed as 283533
6 years, 5 months ago (2014-07-16 21:57:39 UTC) #28
blundell
6 years, 5 months ago (2014-07-21 14:03:12 UTC) #29
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698