Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 382933002: add url_utils to common repo from skia repo (Closed)

Created:
6 years, 5 months ago by epoger
Modified:
6 years, 5 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/common.git@master
Visibility:
Public.

Description

add url_utils to common repo from skia repo Once gs_utils.py is moved into common, these would be the only files left in https://skia.googlesource.com/skia/+/master/tools/pyutils/ . So let's just move them all... BUG=skia:2682 R=borenet@google.com Committed: https://skia.googlesource.com/common/+/0ad95c1

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -0 lines) Patch
A py/utils/url_utils.py View 1 chunk +61 lines, -0 lines 4 comments Download
A py/utils/url_utils_test.py View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
epoger
Eric- PTAL at patchset 1
6 years, 5 months ago (2014-07-10 19:39:42 UTC) #1
borenet
LGTM with the usual copy/paste question. https://codereview.chromium.org/382933002/diff/1/py/utils/url_utils.py File py/utils/url_utils.py (right): https://codereview.chromium.org/382933002/diff/1/py/utils/url_utils.py#newcode1 py/utils/url_utils.py:1: #!/usr/bin/python Is this ...
6 years, 5 months ago (2014-07-10 19:42:32 UTC) #2
epoger
https://codereview.chromium.org/382933002/diff/1/py/utils/url_utils.py File py/utils/url_utils.py (right): https://codereview.chromium.org/382933002/diff/1/py/utils/url_utils.py#newcode1 py/utils/url_utils.py:1: #!/usr/bin/python On 2014/07/10 19:42:32, borenet wrote: > Is this ...
6 years, 5 months ago (2014-07-10 19:44:03 UTC) #3
epoger
6 years, 5 months ago (2014-07-10 19:45:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r0ad95c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698