Issue 382833004: Remove StartAsyncDispatchNotifications from inspector_websocket

Issue 382833004: Remove StartAsyncDispatchNotifications from inspector_websocket (Closed)

Created:
6 years, 5 months ago by nednguyen

Modified:
6 years, 5 months ago

Reviewers:
Ken Russell (switch to Gerrit), tonyg, chrishenry, nduca

CC:
chromium-reviews, telemetry+watch_chromium.org, dtu

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove StartAsyncDispatchNotifications from inspector_websocket since it's not needed by tracing backend. BUG=392044 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282572

Patch Set 1 #

Patch Set 2 : Update default timeout value for StopTracing call to 30s #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -28 lines)			Patch
	M	tools/telemetry/telemetry/core/backends/chrome/inspector_websocket.py	View		4 chunks	+26 lines, -22 lines	0 comments	Download
	M	tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py	View	1	4 chunks	+21 lines, -6 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

Please point this CL to a bug ID in case it has to be reverted ...

6 years, 5 months ago (2014-07-10 22:48:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/382833004/40001

6 years, 5 months ago (2014-07-11 04:18:53 UTC) #5

chrishenry

6 years, 5 months ago (2014-07-11 18:28:00 UTC) #7

Message was sent while issue was closed.

lgtm, nice!

https://codereview.chromium.org/382833004/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py (right):

https://codereview.chromium.org/382833004/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py:166: 'time out
amount.' % err.elapsed_time)
nit: timeout

Expand Messages | Collapse Messages