Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 382833003: Revert of IDL: Treat undefined as missing for optional arguments with defaults (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp
index 24c082091026bfac7b731e14e7c0d3294264d4da..0e64c0360929c3a48c083492a4d80dedd528cf2d 100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -7280,7 +7280,7 @@
{
v8::TryCatch block;
V8RethrowTryCatchScope rethrow(block);
- if (!info[0]->IsUndefined()) {
+ if (info.Length() > 0) {
TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(defaultByteStringArg, toByteString(info[0], exceptionState), exceptionState);
} else {
defaultByteStringArg = String("foo");
@@ -7301,7 +7301,7 @@
TestObject* impl = V8TestObject::toNative(info.Holder());
V8StringResource<> defaultStringArg;
{
- if (!info[0]->IsUndefined()) {
+ if (info.Length() > 0) {
TOSTRING_VOID_INTERNAL(defaultStringArg, info[0]);
} else {
defaultStringArg = String("foo");
@@ -7327,17 +7327,17 @@
{
v8::TryCatch block;
V8RethrowTryCatchScope rethrow(block);
- if (!info[0]->IsUndefined()) {
+ if (info.Length() > 0) {
TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(defaultLongArg, toInt32(info[0], exceptionState), exceptionState);
} else {
defaultLongArg = 10;
}
- if (!info[1]->IsUndefined()) {
+ if (info.Length() > 1) {
TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(defaultLongLongArg, toInt64(info[1], exceptionState), exceptionState);
} else {
defaultLongLongArg = -10;
}
- if (!info[2]->IsUndefined()) {
+ if (info.Length() > 2) {
TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(defaultUnsignedArg, toUInt32(info[2], exceptionState), exceptionState);
} else {
defaultUnsignedArg = 4294967295u;
@@ -7360,7 +7360,7 @@
{
v8::TryCatch block;
V8RethrowTryCatchScope rethrow(block);
- if (!info[0]->IsUndefined()) {
+ if (info.Length() > 0) {
TONATIVE_VOID_INTERNAL(defaultDoubleArg, static_cast<double>(info[0]->NumberValue()));
} else {
defaultDoubleArg = 0.5;
@@ -7383,7 +7383,7 @@
{
v8::TryCatch block;
V8RethrowTryCatchScope rethrow(block);
- if (!info[0]->IsUndefined()) {
+ if (info.Length() > 0) {
TONATIVE_VOID_INTERNAL(defaultBooleanArg, info[0]->BooleanValue());
} else {
defaultBooleanArg = true;
@@ -7406,7 +7406,7 @@
{
v8::TryCatch block;
V8RethrowTryCatchScope rethrow(block);
- if (!info[0]->IsUndefined()) {
+ if (info.Length() > 0) {
TONATIVE_VOID_INTERNAL(defaultBooleanArg, info[0]->BooleanValue());
} else {
defaultBooleanArg = false;
@@ -7429,7 +7429,7 @@
{
v8::TryCatch block;
V8RethrowTryCatchScope rethrow(block);
- if (!info[0]->IsUndefined()) {
+ if (info.Length() > 0) {
TONATIVE_VOID_INTERNAL(defaultStringArg, toByteString(info[0]));
} else {
defaultStringArg = nullptr;
@@ -7450,7 +7450,7 @@
TestObject* impl = V8TestObject::toNative(info.Holder());
V8StringResource<TreatNullAsNullString> defaultStringArg;
{
- if (!info[0]->IsUndefined()) {
+ if (info.Length() > 0) {
TOSTRING_VOID_INTERNAL(defaultStringArg, info[0]);
} else {
defaultStringArg = nullptr;
@@ -7473,7 +7473,7 @@
{
v8::TryCatch block;
V8RethrowTryCatchScope rethrow(block);
- if (!info[0]->IsUndefined()) {
+ if (info.Length() > 0) {
TONATIVE_VOID_INTERNAL(defaultTestInterfaceArg, V8TestInterface::toNativeWithTypeCheck(info.GetIsolate(), info[0]));
} else {
defaultTestInterfaceArg = nullptr;
@@ -8030,7 +8030,7 @@
{
v8::TryCatch block;
V8RethrowTryCatchScope rethrow(block);
- if (!info[0]->IsUndefined()) {
+ if (info.Length() > 0) {
TONATIVE_VOID_INTERNAL(testInterfaceEmptyOrNullArg, V8TestInterfaceEmpty::toNativeWithTypeCheck(info.GetIsolate(), info[0]));
} else {
testInterfaceEmptyOrNullArg = nullptr;
« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698