components/policy/core/common/cloud/cloud_policy_validator.h - Issue 382813002: Added more policy UMA metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/cloud_policy_validator.h

Issue 382813002: Added more policy UMA metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: More review feedback. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/common/cloud/cloud_policy_validator.h

diff --git a/components/policy/core/common/cloud/cloud_policy_validator.h b/components/policy/core/common/cloud/cloud_policy_validator.h

index 9eb781c7c13c5a08e1adb0cfda64d59612602661..eaa801adb02c378fd891212288f1fec67d4b7c78 100644

--- a/components/policy/core/common/cloud/cloud_policy_validator.h

+++ b/components/policy/core/common/cloud/cloud_policy_validator.h

@@ -48,7 +48,8 @@ class POLICY_EXPORT CloudPolicyValidatorBase {

public:

// Validation result codes. These values are also used for UMA histograms by

// UserCloudPolicyStoreChromeOS and must stay stable - new elements should

- // be added at the end before VALIDATION_STATUS_SIZE.

+ // be added at the end before VALIDATION_STATUS_SIZE. Also update the

+ // associated enum definition in histograms.xml.

enum Status {

// Indicates successful validation.

VALIDATION_OK,