tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 54d905b02533ebbeddfa6dcc3bfd5067e084f723..c83bfbf346ed53d293c138717ca5e87eb3ae80ef 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -5315,6 +5315,22 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Enterprise.DomainWhitelistRegexFailureIndex">

[Ilya Sherman, 2014/07/11 22:54:13]

Please associate an enum with this histogram, rather than just tracking an
opaque index.

[Andrew T Wilson (Slow), 2014/07/24 15:25:56]

Done.

+  <owner>atwilson@chromium.org</owner>
+  <summary>
+    Tracks which domain caused an IcuMatcher initialization failure, to help

[Ilya Sherman, 2014/07/11 22:54:12]

What is an IcuMatcher?  Codesearch gives zero hits for this term.

[Andrew T Wilson (Slow), 2014/07/24 15:25:56]

Updated this to icu::RegexMatcher

+    figure out the cause of http://crbug.com/365351.
+  </summary>
+</histogram>
+
+<histogram name="Enterprise.DomainWhitelistRegexSuccess" enum="Boolean">

[Ilya Sherman, 2014/07/11 22:54:13]

Please associate a more semantically contentful enum.  It's currently unclear to
me, from the combination of the <summary> and the enum, what this histogram is
actually measuring.

[Andrew T Wilson (Slow), 2014/07/24 15:25:56]

OK, I didn't realize that best practices recommended that we add new BooleanXXXX
enums to capture this semantic information. I've added this.

+  <owner>atwilson@chromium.org</owner>
+  <summary>
+    Tracks instances of IcuMatcher initialization, to help figure out the cause
+    of http://crbug.com/365351.
+  </summary>
+</histogram>
+
 <histogram name="Enterprise.EnrolledPolicyHasDMToken" enum="Boolean">
   <owner>tnagel@chromium.org</owner>
   <summary>
@@ -5361,6 +5377,13 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Enterprise.PolicyHasVerifiedCachedKey" enum="Boolean">

[Ilya Sherman, 2014/07/11 22:54:12]

Please associate a more semantically contentful enum.

[Andrew T Wilson (Slow), 2014/07/24 15:25:56]

Done.

+  <owner>atwilson@chromium.org</owner>
+  <summary>
+    Boolean tracking whether there is a policy signing key on disk.
+  </summary>
+</histogram>
+
 <histogram name="Enterprise.PolicyInvalidations"
     enum="EnterprisePolicyInvalidations">
   <owner>joaodasilva@chromium.org</owner>
@@ -5398,6 +5421,31 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Enterprise.UserCloudPolicyStore.LoadStatus"
+    enum="PolicyLoadStatus">
+  <owner>atwilson@chromium.org</owner>
+  <summary>
+    Result of the attempted policy load during profile initialization.
+  </summary>
+</histogram>
+
+<histogram name="Enterprise.UserCloudPolicyStore.LoadValidationStatus"
+    enum="PolicyValidationStatus">
+  <owner>atwilson@chromium.org</owner>
+  <summary>
+    Result of validating the policy that has just been loaded from disk.
+  </summary>
+</histogram>
+
+<histogram name="Enterprise.UserCloudPolicyStore.StoreValidationStatus"
+    enum="PolicyValidationStatus">
+  <owner>atwilson@chromium.org</owner>
+  <summary>
+    Result of validating the policy sent down from the server, before writing to
+    disk.
+  </summary>
+</histogram>
+
 <histogram name="Enterprise.UserPolicyChromeOS.DelayInitialization"
     units="milliseconds">
   <owner>joaodasilva@chromium.org</owner>
@@ -5447,6 +5495,35 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <summary>Network error during OAuth2 access token fetch.</summary>
 </histogram>
 
+<histogram name="Enterprise.UserPolicyValidationFailure"
+    enum="ValidationFailures">
+  <owner>mnissler@chromium.org</owner>
+  <summary>Source of policy validation errors on ChromeOS.</summary>
+</histogram>
+
+<histogram name="Enterprise.UserPolicyValidationLoadStatus"
+    enum="PolicyValidationStatus">
+  <owner>mnissler@chromium.org</owner>
+  <summary>
+    Validation result when loading user policy from the policy store.
+  </summary>
+</histogram>
+
+<histogram name="Enterprise.UserPolicyValidationStoreStatus"
+    enum="PolicyValidationStatus">
+  <owner>mnissler@chromium.org</owner>
+  <summary>
+    Validation result when writing user policy to the policy store.
+  </summary>
+</histogram>
+
+<histogram name="Enterprise.UserSigninChoice" enum="SigninChoice">
+  <owner>atwilson@chromium.org</owner>
+  <summary>
+    Choice the user made when presented with enterprise signin dialog.
+  </summary>
+</histogram>
+
 <histogram name="Enterprise.WildcardLoginCheck.DelayPolicyTokenFetch"
     units="milliseconds">
   <owner>joaodasilva@chromium.org</owner>
@@ -44228,6 +44305,27 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="5" label="5"/>
 </enum>
 
+<enum name="PolicyLoadStatus" type="int">
+  <int value="0" label="Success"/>
+  <int value="1" label="No Policy File"/>
+  <int value="2" label="Load Error"/>
+</enum>
+
+<enum name="PolicyValidationStatus" type="int">
+  <int value="0" label="OK"/>
+  <int value="1" label="Bad Initial Signature"/>
+  <int value="2" label="Bad Signature"/>
+  <int value="3" label="Policy Error Code"/>
+  <int value="4" label="Payload Parse Error"/>
+  <int value="5" label="Wrong Policy Type"/>
+  <int value="6" label="Wrong Settings Entity ID"/>
+  <int value="7" label="Bad Timestamp"/>
+  <int value="8" label="Wrong Token"/>
+  <int value="9" label="Wrong Username"/>
+  <int value="10" label="Policy Parse Error"/>
+  <int value="11" label="Bad Key Validation Signature"/>
+</enum>
+
 <enum name="PostMergeVerificationOutcome" type="int">
   <int value="0" label="Undefined"/>
   <int value="1" label="Succeeded"/>
@@ -45924,6 +46022,12 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="2" label="Dismiss"/>
 </enum>
 
+<enum name="SigninChoice" type="int">
+  <int value="0" label="Cancel"/>
+  <int value="1" label="Continue"/>
+  <int value="2" label="New Profile"/>
+</enum>
+
 <enum name="SigninFlowConfirmations" type="int">
   <int value="0" label="Shown"/>
   <int value="1" label="OK"/>
@@ -47648,6 +47752,11 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="5" label="Kiosk App"/>
 </enum>
 
+<enum name="ValidationFailures" type="int">
+  <int value="0" label="DBus"/>
+  <int value="1" label="Load Key"/>
+</enum>
+
 <enum name="VariationSeedSignature" type="int">
   <int value="0" label="Signature Missing"/>
   <int value="1" label="Signature Decode Failed"/>