Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Issue 382693002: Fix possible bad cast in Tab (Closed)

Created:
6 years, 5 months ago by sky
Modified:
6 years, 5 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

It was possible to think we had set tab_animation_ to a MultiAnimation when we hadn't. To avoid errors like this I'm splitting tab_animation_ into two distinct fields. Less possibility of error this way. BUG=387371 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282455

Patch Set 1 #

Patch Set 2 : remove unintended change #

Patch Set 3 : cleanup #

Patch Set 4 : PassAs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -58 lines) Patch
M chrome/browser/ui/views/tabs/tab.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 2 3 11 chunks +45 lines, -54 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
sky
6 years, 5 months ago (2014-07-09 22:56:01 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 5 months ago (2014-07-10 15:49:28 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 5 months ago (2014-07-10 16:03:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/382693002/40001
6 years, 5 months ago (2014-07-10 16:05:09 UTC) #4
sky
The CQ bit was checked by sky@chromium.org
6 years, 5 months ago (2014-07-10 19:27:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/382693002/60001
6 years, 5 months ago (2014-07-10 19:29:15 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 21:30:54 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 21:55:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/169805)
6 years, 5 months ago (2014-07-10 21:55:48 UTC) #9
sky
The CQ bit was checked by sky@chromium.org
6 years, 5 months ago (2014-07-10 23:12:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/382693002/60001
6 years, 5 months ago (2014-07-10 23:14:11 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 23:15:55 UTC) #12
Message was sent while issue was closed.
Change committed as 282455

Powered by Google App Engine
This is Rietveld 408576698