Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 382683002: Add basic support of URL/search query to Athena home card. (Closed)

Created:
6 years, 5 months ago by Jun Mukai
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add basic support of URL/search query to Athena home card. It still takes time to componentize autocomplete input and search features. However, we have componentized some important parts already. The added code will be replaced by the real autocomplete code in the future, but meanwhile, this is good enough. Feature: - the logic to check if the input looks like URL / host names - canonicalize the input to form the actual URL (http://...) - use TemplateURLService to create the search result page URL if it looks like a query. BUG=387207 R=oshima@chromium.org, hashimoto@chromium.org TBR=pkasting@chromium.org, jar@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282497

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix #

Patch Set 3 : git-cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -7 lines) Patch
M athena/main/DEPS View 1 1 chunk +4 lines, -0 lines 0 comments Download
M athena/main/athena_main.gyp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M athena/main/url_search_provider.h View 2 chunks +6 lines, -0 lines 0 comments Download
M athena/main/url_search_provider.cc View 1 2 5 chunks +91 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Jun Mukai
6 years, 5 months ago (2014-07-09 22:10:18 UTC) #1
hashimoto
lgtm https://codereview.chromium.org/382683002/diff/1/athena/main/athena_main.gyp File athena/main/athena_main.gyp (right): https://codereview.chromium.org/382683002/diff/1/athena/main/athena_main.gyp#newcode23 athena/main/athena_main.gyp:23: '../../components/components.gyp:autocomplete_test_support', Why don't you create a simple scheme ...
6 years, 5 months ago (2014-07-10 03:14:27 UTC) #2
oshima
lgtm can you run git cl format if you haven't already done so.
6 years, 5 months ago (2014-07-10 17:46:13 UTC) #3
Jun Mukai
also ran git-cl format https://codereview.chromium.org/382683002/diff/1/athena/main/athena_main.gyp File athena/main/athena_main.gyp (right): https://codereview.chromium.org/382683002/diff/1/athena/main/athena_main.gyp#newcode23 athena/main/athena_main.gyp:23: '../../components/components.gyp:autocomplete_test_support', On 2014/07/10 03:14:27, hashimoto ...
6 years, 5 months ago (2014-07-10 17:59:54 UTC) #4
Jun Mukai
submit with TBR=pkasting and jar for adding new DEPS in athena/main for components/autocomplete, components/metrics/proto, components/search_engines, ...
6 years, 5 months ago (2014-07-10 18:01:11 UTC) #5
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 5 months ago (2014-07-10 18:01:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/382683002/40001
6 years, 5 months ago (2014-07-10 18:03:37 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 21:36:54 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 23:12:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/47860)
6 years, 5 months ago (2014-07-10 23:12:54 UTC) #10
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 5 months ago (2014-07-10 23:15:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/382683002/40001
6 years, 5 months ago (2014-07-10 23:17:00 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 01:47:21 UTC) #13
Message was sent while issue was closed.
Change committed as 282497

Powered by Google App Engine
This is Rietveld 408576698