Fixes for re-enabling more MSVC level 4 warnings: misc edition #2

google_apis/gcm/engine/mcs_client.cc

Index: google_apis/gcm/engine/mcs_client.cc
diff --git a/google_apis/gcm/engine/mcs_client.cc b/google_apis/gcm/engine/mcs_client.cc
index a99a333a37e0d694c0a5233ef76012c9d89947d1..96db2809d4e86ed558eb0a70e2fbaed8d72aad30 100644
--- a/google_apis/gcm/engine/mcs_client.cc
+++ b/google_apis/gcm/engine/mcs_client.cc
@@ -770,7 +770,8 @@ void MCSClient::HandleStreamAck(StreamId last_stream_id_received) {
 void MCSClient::HandleSelectiveAck(const PersistentIdList& id_list) {
   std::set<PersistentId> remaining_ids(id_list.begin(), id_list.end());
 
-  StreamId last_stream_id_received = -1;
+  // !!! This looks really wrong, shouldn't this be zero?
+  StreamId last_stream_id_received = 0xFFFFFFFF;

[Peter Kasting, 2014/07/09 22:19:54]

This needs review.  See how code below tries to check whether other values are
greater than this.

[Nicolas Zea, 2014/07/09 22:52:35]

You're right, this is broken. The lines at 815 are effectively dead code at the
moment. I suspect the only effect this has though is one of inefficiency.

And yes, the right solution here is to set the value to 0. I've filed
crbug.com/392664 to better test this code (looks like it wasn't verifying the
internal ack state properly).

[Peter Kasting, 2014/07/09 23:34:25]

Done.

 
   // First check the to_resend_ queue. Acknowledgments are always contiguous,
   // so if there's a pending message that hasn't been acked, all newer messages