Fixes for re-enabling more MSVC level 4 warnings: misc edition #2

sync/internal_api/sync_manager_impl_unittest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Unit tests for the SyncApi. Note that a lot of the underlying
 // functionality is provided by the Syncable layer, which has its own
 // unit tests. We'll test SyncApi specific things in this harness.
 
 #include <cstddef>
 #include <map>
@@ skipping 2844 matching lines @@
   // found.  Returns -1 on lookup failure.
   size_t FindChangeInList(int64 id, ChangeRecord::Action action) {
     SCOPED_TRACE(id);
     for (size_t i = 0; i < last_changes_.Get().size(); ++i) {
       if (last_changes_.Get()[i].id == id
           && last_changes_.Get()[i].action == action) {
         return i;
       }
     }
     ADD_FAILURE() << "Failed to find specified change";
-    return -1;
+    return static_cast<size_t>(-1);
   }
 
   // Returns the current size of the change list.
   //
   // Note that spurious changes do not necessarily indicate a problem.
   // Assertions on change list size can help detect problems, but it may be
   // necessary to reduce their strictness if the implementation changes.
   size_t GetChangeListSize() {
     return last_changes_.Get().size();
   }
@@ skipping 251 matching lines @@
 // SyncManagerInitInvalidStorageTest::GetFactory will return
 // DirectoryBackingStore that ensures that SyncManagerImpl::OpenDirectory fails.
 // SyncManagerImpl initialization is done in SyncManagerTest::SetUp. This test's
 // task is to ensure that SyncManagerImpl reported initialization failure in
 // OnInitializationComplete callback.
 TEST_F(SyncManagerInitInvalidStorageTest, FailToOpenDatabase) {
   EXPECT_FALSE(initialization_succeeded_);
 }
 
 }  // namespace syncer