Fixes for re-enabling more MSVC level 4 warnings: misc edition #2

skia/ext/platform_canvas_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(awalker): clean up the const/non-const reference handling in this test
 
 #include "build/build_config.h"
 
 #if defined(OS_MACOSX)
 #import <ApplicationServices/ApplicationServices.h>
 #endif
 
 #if !defined(OS_WIN)
 #include <unistd.h>
 #endif
 
 #include "base/memory/scoped_ptr.h"
 #include "skia/ext/platform_canvas.h"
 #include "skia/ext/platform_device.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/skia/include/core/SkColor.h"
+#include "third_party/skia/include/core/SkColorPriv.h"
 #include "third_party/skia/include/core/SkPixelRef.h"
 
 namespace skia {
 
 namespace {
 
+bool IsOfColor(const SkBitmap& bitmap, int x, int y, uint32_t color) {
+  // For masking out the alpha values.
+  static uint32_t alpha_mask =
+      static_cast<uint32_t>(SK_A32_MASK) << SK_A32_SHIFT;
+  return (*bitmap.getAddr32(x, y) | alpha_mask) == (color | alpha_mask);
+}
+
 // Return true if the canvas is filled to canvas_color, and contains a single
 // rectangle filled to rect_color. This function ignores the alpha channel,
 // since Windows will sometimes clear the alpha channel when drawing, and we
 // will fix that up later in cases it's necessary.
 bool VerifyRect(const PlatformCanvas& canvas,
                 uint32_t canvas_color, uint32_t rect_color,
                 int x, int y, int w, int h) {
   SkBaseDevice* device = skia::GetTopDevice(canvas);
   const SkBitmap& bitmap = device->accessBitmap(false);
   SkAutoLockPixels lock(bitmap);
 
-  // For masking out the alpha values.
-  uint32_t alpha_mask = 0xFF << SK_A32_SHIFT;
-
   for (int cur_y = 0; cur_y < bitmap.height(); cur_y++) {
     for (int cur_x = 0; cur_x < bitmap.width(); cur_x++) {
       if (cur_x >= x && cur_x < x + w &&
           cur_y >= y && cur_y < y + h) {
         // Inside the square should be rect_color
-        if ((*bitmap.getAddr32(cur_x, cur_y) | alpha_mask) !=
-            (rect_color | alpha_mask))
+        if (!IsOfColor(bitmap, cur_x, cur_y, rect_color))
           return false;
       } else {
         // Outside the square should be canvas_color
-        if ((*bitmap.getAddr32(cur_x, cur_y) | alpha_mask) !=
-            (canvas_color | alpha_mask))
+        if (!IsOfColor(bitmap, cur_x, cur_y, canvas_color))
           return false;
       }
     }
   }
   return true;
 }
 
 #if !defined(OS_MACOSX)
-bool IsOfColor(const SkBitmap& bitmap, int x, int y, uint32_t color) {
-  // For masking out the alpha values.
-  static uint32_t alpha_mask = 0xFF << SK_A32_SHIFT;
-  return (*bitmap.getAddr32(x, y) | alpha_mask) == (color | alpha_mask);
-}
-
 // Return true if canvas has something that passes for a rounded-corner
 // rectangle. Basically, we're just checking to make sure that the pixels in the
 // middle are of rect_color and pixels in the corners are of canvas_color.
 bool VerifyRoundedRect(const PlatformCanvas& canvas,
                        uint32_t canvas_color, uint32_t rect_color,
                        int x, int y, int w, int h) {
   SkBaseDevice* device = skia::GetTopDevice(canvas);
   const SkBitmap& bitmap = device->accessBitmap(false);
   SkAutoLockPixels lock(bitmap);
 
@@ skipping 369 matching lines @@
 
   sk_bitmap.lockPixels();
   EXPECT_EQ(0xDEED1020, *sk_bitmap.getAddr32(10, 20));
   EXPECT_EQ(0xDEED2030, *sk_bitmap.getAddr32(20, 30));
   EXPECT_EQ(0xDEED3040, *sk_bitmap.getAddr32(30, 40));
   sk_bitmap.unlockPixels();
 }
 
 
 }  // namespace skia