Fixes for re-enabling more MSVC level 4 warnings: misc edition #2

google_apis/gaia/fake_gaia.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/gaia/fake_gaia.h"
 
 #include <vector>
 
 #include "base/base_paths.h"
 #include "base/bind.h"
@@ skipping 395 matching lines @@
   }
   std::string relay_state;
   GetQueryParameter(request.content, "RelayState", &relay_state);
   std::string redirect_url = relay_state;
   http_response->set_code(net::HTTP_TEMPORARY_REDIRECT);
   http_response->AddCustomHeader("Location", redirect_url);
 }
 
 void FakeGaia::HandleAuthToken(const HttpRequest& request,
                                BasicHttpResponse* http_response) {
-  std::string grant_type;
-  std::string refresh_token;
-  std::string client_id;
   std::string scope;
-  std::string auth_code;
-  const AccessTokenInfo* token_info = NULL;
   GetQueryParameter(request.content, "scope", &scope);
 
+  std::string grant_type;
   if (!GetQueryParameter(request.content, "grant_type", &grant_type)) {
     http_response->set_code(net::HTTP_BAD_REQUEST);
     LOG(ERROR) << "No 'grant_type' param in /o/oauth2/token";
     return;
   }
 
   if (grant_type == "authorization_code") {
+    std::string auth_code;
     if (!GetQueryParameter(request.content, "code", &auth_code) ||
         auth_code != merge_session_params_.auth_code) {
       http_response->set_code(net::HTTP_BAD_REQUEST);
       LOG(ERROR) << "No 'code' param in /o/oauth2/token";
       return;
     }
 
     if (GaiaConstants::kOAuth1LoginScope != scope) {
       http_response->set_code(net::HTTP_BAD_REQUEST);
       LOG(ERROR) << "Invalid scope for /o/oauth2/token - " << scope;
       return;
     }
 
     base::DictionaryValue response_dict;
     response_dict.SetString("refresh_token",
                             merge_session_params_.refresh_token);
     response_dict.SetString("access_token",
                             merge_session_params_.access_token);
     response_dict.SetInteger("expires_in", 3600);
     FormatJSONResponse(response_dict, http_response);
-  } else if (GetQueryParameter(request.content,
-                               "refresh_token",
-                               &refresh_token) &&
-             GetQueryParameter(request.content,
-                               "client_id",
-                               &client_id) &&
-             (token_info = FindAccessTokenInfo(refresh_token,
-                                              client_id,
-                                              scope))) {
-    base::DictionaryValue response_dict;
-    response_dict.SetString("access_token", token_info->token);
-    response_dict.SetInteger("expires_in", 3600);
-    FormatJSONResponse(response_dict, http_response);
-  } else {
-    LOG(ERROR) << "Bad request for /o/oauth2/token - "
-               << "refresh_token = " << refresh_token
-               << ", scope = " << scope
-               << ", client_id = " << client_id;
-    http_response->set_code(net::HTTP_BAD_REQUEST);
+    return;
   }
+
+  std::string refresh_token;
+  std::string client_id;
+  if (GetQueryParameter(request.content, "refresh_token", &refresh_token) &&
+      GetQueryParameter(request.content, "client_id", &client_id)) {
+    const AccessTokenInfo* token_info =
+        FindAccessTokenInfo(refresh_token, client_id, scope);
+    if (token_info) {
+      base::DictionaryValue response_dict;
+      response_dict.SetString("access_token", token_info->token);
+      response_dict.SetInteger("expires_in", 3600);
+      FormatJSONResponse(response_dict, http_response);
+      return;
+    }
+  }
+
+  LOG(ERROR) << "Bad request for /o/oauth2/token - "
+              << "refresh_token = " << refresh_token
+              << ", scope = " << scope
+              << ", client_id = " << client_id;
+  http_response->set_code(net::HTTP_BAD_REQUEST);
 }
 
 void FakeGaia::HandleTokenInfo(const HttpRequest& request,
                                BasicHttpResponse* http_response) {
   const AccessTokenInfo* token_info = NULL;
   std::string access_token;
   if (GetQueryParameter(request.content, "access_token", &access_token)) {
     for (AccessTokenInfoMap::const_iterator entry(
              access_token_info_map_.begin());
          entry != access_token_info_map_.end();
@@ skipping 19 matching lines @@
   } else {
     http_response->set_code(net::HTTP_BAD_REQUEST);
   }
 }
 
 void FakeGaia::HandleIssueToken(const HttpRequest& request,
                                 BasicHttpResponse* http_response) {
   std::string access_token;
   std::string scope;
   std::string client_id;
-  const AccessTokenInfo* token_info = NULL;
   if (GetAccessToken(request, kAuthHeaderBearer, &access_token) &&
       GetQueryParameter(request.content, "scope", &scope) &&
-      GetQueryParameter(request.content, "client_id", &client_id) &&
-      (token_info = FindAccessTokenInfo(access_token, client_id, scope))) {
-    base::DictionaryValue response_dict;
-    response_dict.SetString("issueAdvice", "auto");
-    response_dict.SetString("expiresIn",
-                            base::IntToString(token_info->expires_in));
-    response_dict.SetString("token", token_info->token);
-    FormatJSONResponse(response_dict, http_response);
-  } else {
-    http_response->set_code(net::HTTP_BAD_REQUEST);
+      GetQueryParameter(request.content, "client_id", &client_id)) {
+    const AccessTokenInfo* token_info =
+        FindAccessTokenInfo(access_token, client_id, scope);
+    if (token_info) {
+      base::DictionaryValue response_dict;
+      response_dict.SetString("issueAdvice", "auto");
+      response_dict.SetString("expiresIn",
+                              base::IntToString(token_info->expires_in));
+      response_dict.SetString("token", token_info->token);
+      FormatJSONResponse(response_dict, http_response);
+      return;
+    }
   }
+  http_response->set_code(net::HTTP_BAD_REQUEST);
 }
 
 void FakeGaia::HandleListAccounts(const HttpRequest& request,
                                  BasicHttpResponse* http_response) {
   http_response->set_content(base::StringPrintf(
       kListAccountsResponseFormat, merge_session_params_.email.c_str()));
   http_response->set_code(net::HTTP_OK);
 }