Fixes for re-enabling more MSVC level 4 warnings: misc edition #2

cloud_print/virtual_driver/win/install/setup.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <iomanip>
 #include <windows.h>
 #include <winspool.h>
 #include <setupapi.h>  // Must be included after windows.h
 
 #include "base/at_exit.h"
@@ skipping 192 matching lines @@
                       temp_path->Append(kDependencyList[i]).value().c_str());
         return FILEOP_DOIT;
       }
     }
     return FILEOP_SKIP;
   }
   return NO_ERROR;
 }
 
 void ReadyDriverDependencies(const base::FilePath& destination) {
+  base::FilePath destination_copy(destination);
   if (base::win::GetVersion() >= base::win::VERSION_VISTA) {
     // GetCorePrinterDrivers and GetPrinterDriverPackagePath only exist on
     // Vista and later. Winspool.drv must be delayloaded so these calls don't
     // create problems on XP.
     DWORD size = MAX_PATH;
     wchar_t package_path[MAX_PATH] = {0};
     CORE_PRINTER_DRIVER driver;
     GetCorePrinterDrivers(NULL, NULL, L"{D20EA372-DD35-4950-9ED8-A6335AFE79F5}",
                           1, &driver);
     GetPrinterDriverPackagePath(NULL, NULL, NULL, driver.szPackageID,
                                 package_path, MAX_PATH, &size);
-    SetupIterateCabinet(package_path, 0, &CabinetCallback,
-                        &base::FilePath(destination));
+    SetupIterateCabinet(package_path, 0, &CabinetCallback, &destination_copy);
   } else {
     // Driver files are in the sp3 cab.
     base::FilePath package_path;
     PathService::Get(base::DIR_WINDOWS, &package_path);
     package_path = package_path.Append(L"Driver Cache\\i386\\sp3.cab");
     SetupIterateCabinet(package_path.value().c_str(), 0, &CabinetCallback,
-                        &base::FilePath(destination));
+                        &destination_copy);
 
     // Copy the rest from the driver cache or system dir.
     base::FilePath driver_cache_path;
     PathService::Get(base::DIR_WINDOWS, &driver_cache_path);
     driver_cache_path = driver_cache_path.Append(L"Driver Cache\\i386");
     for (size_t i = 0; i < arraysize(kDependencyList); ++i) {
       base::FilePath dst_path = destination.Append(kDependencyList[i]);
       if (!base::PathExists(dst_path)) {
         base::FilePath src_path = driver_cache_path.Append(kDependencyList[i]);
         if (!base::PathExists(src_path))
@@ skipping 307 matching lines @@
 
   VLOG(0) << GetErrorMessage(retval)
           << " HRESULT=0x" << std::setbase(16) << retval;
 
   // Installer is silent by default as required by Google Update.
   if (CommandLine::ForCurrentProcess()->HasSwitch("verbose")) {
     DisplayWindowsMessage(NULL, retval, LoadLocalString(IDS_DRIVER_NAME));
   }
   return retval;
 }