Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 382663004: Componentize tests under search_engines (Closed)

Created:
6 years, 5 months ago by hashimoto
Modified:
6 years, 5 months ago
Reviewers:
Peter Kasting, blundell
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Componentize tests under search_engines BUG=387985 TEST=components_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282523

Patch Set 1 #

Total comments: 2

Patch Set 2 : Include search_engines even if os=="ios" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2926 lines) Patch
M chrome/browser/search_engines/DEPS View 1 chunk +1 line, -11 lines 0 comments Download
D chrome/browser/search_engines/default_search_manager_unittest.cc View 1 chunk +0 lines, -324 lines 0 comments Download
D chrome/browser/search_engines/default_search_policy_handler_unittest.cc View 1 chunk +0 lines, -488 lines 0 comments Download
D chrome/browser/search_engines/search_host_to_urls_map_unittest.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc View 1 chunk +0 lines, -351 lines 0 comments Download
D chrome/browser/search_engines/template_url_service_util_unittest.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/browser/search_engines/template_url_unittest.cc View 1 chunk +0 lines, -1539 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -8 lines 0 comments Download
M components/components_tests.gyp View 1 4 chunks +11 lines, -0 lines 0 comments Download
A + components/search_engines/default_search_manager_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/search_engines/default_search_policy_handler_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/search_engines/search_host_to_urls_map_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/search_engines/template_url_prepopulate_data_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
A + components/search_engines/template_url_service_util_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/search_engines/template_url_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
Peter, could you review this change as an owner of search_engines? Colin, could you review ...
6 years, 5 months ago (2014-07-10 07:31:44 UTC) #1
blundell
https://codereview.chromium.org/382663004/diff/1/components/components_tests.gyp File components/components_tests.gyp (right): https://codereview.chromium.org/382663004/diff/1/components/components_tests.gyp#newcode451 components/components_tests.gyp:451: ['include', '^search_provider_logos/'], please add search_engines/ to this list.
6 years, 5 months ago (2014-07-10 07:50:17 UTC) #2
hashimoto
https://codereview.chromium.org/382663004/diff/1/components/components_tests.gyp File components/components_tests.gyp (right): https://codereview.chromium.org/382663004/diff/1/components/components_tests.gyp#newcode451 components/components_tests.gyp:451: ['include', '^search_provider_logos/'], On 2014/07/10 07:50:17, blundell wrote: > please ...
6 years, 5 months ago (2014-07-10 08:52:29 UTC) #3
blundell
//components LGTM
6 years, 5 months ago (2014-07-10 08:54:03 UTC) #4
Peter Kasting
LGTM
6 years, 5 months ago (2014-07-10 18:39:12 UTC) #5
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 5 months ago (2014-07-11 02:34:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/382663004/20001
6 years, 5 months ago (2014-07-11 02:37:57 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 03:14:24 UTC) #8
Message was sent while issue was closed.
Change committed as 282523

Powered by Google App Engine
This is Rietveld 408576698