Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: chrome/common/BUILD.gn

Issue 382663002: Add components and CLD to GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: android Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/renderer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index 6712b5000bff83ac096e931eaebbb0c2c27ce4da..49e7552b3e9274b992ac7c0d2dfc877afbf27c77 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -31,7 +31,6 @@ static_library("common") {
deps = [
":version",
- #":installer_util", TODO(GYP)
"//base:base",
"//base:i18n",
"//base:prefs",
@@ -42,17 +41,15 @@ static_library("common") {
"//chrome/common:constants",
"//chrome/common/net",
"//chrome/common/safe_browsing:proto",
- #"//components/cloud_devices:common", TODO(GYP)
- #"//components/json_schema", TODO(GYP)
- "//components/metrics",
- #"//components/components.gyp:policy_component_common", TODO(GYP)
- "//components/translate:translate_core_common",
+ "//components/cloud_devices/common",
+ "//components/metrics",
+ "//components/policy:policy_component_common",
+ "//components/translate/core/common",
"//components/variations",
"//content/public/common",
"//crypto",
"//extensions:extensions_resources",
"//extensions/strings",
- #"//media/cast/cast.gyp:cast_transport", TODO(GYP)
"//net",
"//skia",
"//third_party/icu",
@@ -61,24 +58,27 @@ static_library("common") {
"//third_party/zlib:zip",
"//ui/resources:resources",
"//url",
+ #":installer_util", TODO(GYP)
+ #"//components/json_schema", TODO(GYP)
+ #"//media/cast/cast.gyp:cast_transport", TODO(GYP)
]
if (!is_ios) {
deps += [
"//chrome/common/extensions/api",
- #'<(DEPTH)/components/components.gyp:autofill_core_common', TODO(GYP)
- #'<(DEPTH)/components/components.gyp:autofill_content_common', TODO(GYP)
- #'<(DEPTH)/components/components.gyp:password_manager_core_common', TODO(GYP)
- #'<(DEPTH)/components/components.gyp:signin_core_common', TODO(GYP)
- #'<(DEPTH)/components/components.gyp:translate_content_common', TODO(GYP)
- #'<(DEPTH)/components/nacl.gyp:nacl_common', TODO(GYP)
"//components/visitedlink/common",
- #'<(DEPTH)/extensions/common/api/api.gyp:extensions_api', TODO(GYP)
- #'<(DEPTH)/extensions/extensions.gyp:extensions_common', TODO(GYP)
+ "//components/autofill/content/common",
+ "//components/autofill/core/common",
+ "//components/translate/content/common",
"//ipc",
"//third_party/adobe/flash:flapper_version_h",
"//third_party/re2",
"//third_party/widevine/cdm:version_h",
+ #'<(DEPTH)/components/components.gyp:password_manager_core_common', TODO(GYP)
+ #'<(DEPTH)/components/components.gyp:signin_core_common', TODO(GYP)
+ #'<(DEPTH)/components/nacl.gyp:nacl_common', TODO(GYP)
+ #'<(DEPTH)/extensions/common/api/api.gyp:extensions_api', TODO(GYP)
+ #'<(DEPTH)/extensions/extensions.gyp:extensions_common', TODO(GYP)
]
}
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/renderer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698