Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 382633009: Use EVP_DigestSign* rather than EVP_Sign* in SignatureCreator. (Closed)

Created:
6 years, 5 months ago by davidben
Modified:
5 years, 11 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use EVP_DigestSign* rather than EVP_Sign* in SignatureCreator. Avoids having to hold on to the key separately. EVP_DigestSign is tidier about bounds checks and maximum buffer size. Also account for the return values having been normalized. BUG=none Committed: https://crrev.com/183ce6363d441d4d5c46682d76dc774166727105 Cr-Commit-Position: refs/heads/master@{#312357}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : return values are saner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M crypto/signature_creator.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M crypto/signature_creator_nss.cc View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M crypto/signature_creator_openssl.cc View 1 2 2 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
Had this lying around. Just an inconsequential bit of cleanup.
5 years, 11 months ago (2015-01-20 19:15:38 UTC) #2
Ryan Sleevi
lgtm
5 years, 11 months ago (2015-01-21 01:15:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/382633009/40001
5 years, 11 months ago (2015-01-21 01:16:32 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-21 14:22:05 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 14:22:59 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/183ce6363d441d4d5c46682d76dc774166727105
Cr-Commit-Position: refs/heads/master@{#312357}

Powered by Google App Engine
This is Rietveld 408576698