Issue 382633008: Followup to r177831.

Issue 382633008: Followup to r177831. (Closed)

Created:
6 years, 5 months ago by sof

Modified:
6 years, 5 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Followup to r177831. Extend the nodeToIdMap by calling set() rather than update the end() iterator. R=haraken@chromium.org BUG=340522 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177841

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update nodeToIdMap #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/core/inspector/InspectorNodeIds.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

sof

Please take a look. I don't understand the purpose of this assignment. Crashes webkit_unit_tests (dbg.)

6 years, 5 months ago (2014-07-10 15:08:53 UTC) #1

haraken

Sorry about the breakage... https://codereview.chromium.org/382633008/diff/1/Source/core/inspector/InspectorNodeIds.cpp File Source/core/inspector/InspectorNodeIds.cpp (left): https://codereview.chromium.org/382633008/diff/1/Source/core/inspector/InspectorNodeIds.cpp#oldcode40 Source/core/inspector/InspectorNodeIds.cpp:40: it->value = id; I think ...

6 years, 5 months ago (2014-07-10 15:14:04 UTC) #2

sof

https://codereview.chromium.org/382633008/diff/1/Source/core/inspector/InspectorNodeIds.cpp File Source/core/inspector/InspectorNodeIds.cpp (left): https://codereview.chromium.org/382633008/diff/1/Source/core/inspector/InspectorNodeIds.cpp#oldcode40 Source/core/inspector/InspectorNodeIds.cpp:40: it->value = id; On 2014/07/10 15:14:04, haraken wrote: > ...

6 years, 5 months ago (2014-07-10 15:18:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/382633008/20001

6 years, 5 months ago (2014-07-10 15:22:38 UTC) #6

Message was sent while issue was closed.

Change committed as 177841

Expand Messages | Collapse Messages