Issue 382633003: Mojo: Mojom: Fix NodeList's __eq__ (only used in testing).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 382633003: Mojo: Mojom: Fix NodeList's eq (only used in testing). (Closed)

Created:
6 years, 5 months ago by viettrungluu

Modified:
6 years, 5 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: Mojom: Fix NodeList's __eq__ (only used in testing). I really managed to botch it. Surprisingly, the tests were all still okay. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282168

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -8 lines)			Patch
	M	mojo/public/tools/bindings/pylib/mojom/parse/ast.py	View		3 chunks	+13 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/382633003/1

6 years, 5 months ago (2014-07-09 21:09:51 UTC) #4

viettrungluu

6 years, 5 months ago (2014-07-09 23:14:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r282168 (presubmit successful).

Expand Messages | Collapse Messages

Issue 382633003: Mojo: Mojom: Fix NodeList's __eq__ (only used in testing). (Closed)

Description

Patch Set 1 #

Messages

Issue 382633003: Mojo: Mojom: Fix NodeList's eq (only used in testing). (Closed)