Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 382633002: Fix use_canvas_skia = 0 (Closed)

Created:
6 years, 5 months ago by zhaoze.zhou
Modified:
6 years, 5 months ago
CC:
chromium-reviews, kbalazs
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 : fix use_canvas_skia under linux #

Patch Set 2 : Rename non-implemented file #

Patch Set 3 : Change file name to keep persistence #

Patch Set 4 : Temp fix for gn build #

Total comments: 3

Patch Set 5 : Style fix #

Total comments: 2

Patch Set 6 : Remove flags in the gni file #

Patch Set 7 : Remove the flags in gni #

Patch Set 8 : Upstream changes, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -43 lines) Patch
M ui/gfx/BUILD.gn View 1 2 3 4 5 6 7 2 chunks +3 lines, -1 line 0 comments Download
D ui/gfx/canvas_android.cc View 1 1 chunk +0 lines, -40 lines 0 comments Download
A + ui/gfx/canvas_notimplemented.cc View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 36 (0 generated)
zhaoze.zhou
6 years, 5 months ago (2014-07-14 21:36:00 UTC) #1
zhaoze.zhou
Please take a look.
6 years, 5 months ago (2014-07-16 23:23:10 UTC) #2
zhaoze.zhou
thakis@chromium.org: Please take a look
6 years, 5 months ago (2014-07-17 12:53:46 UTC) #3
Nico
Looks like asvitkine might know something about this.
6 years, 5 months ago (2014-07-17 16:18:57 UTC) #4
Alexei Svitkine (slow)
lgtm
6 years, 5 months ago (2014-07-17 16:36:45 UTC) #5
zhaoze.zhou
The CQ bit was checked by zhaoze.zhou@partner.samsung.com
6 years, 5 months ago (2014-07-17 16:39:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhaoze.zhou@partner.samsung.com/382633002/100001
6 years, 5 months ago (2014-07-17 16:41:01 UTC) #7
Nico
lgtm
6 years, 5 months ago (2014-07-17 16:46:06 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 20:05:30 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 21:43:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/26915)
6 years, 5 months ago (2014-07-17 21:43:35 UTC) #11
zhaoze.zhou
On 2014/07/17 16:36:45, Alexei Svitkine wrote: > lgtm I have changed some stuff in the ...
6 years, 5 months ago (2014-07-18 20:18:07 UTC) #12
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/382633002/diff/200001/ui/gfx/BUILD.gn File ui/gfx/BUILD.gn (right): https://codereview.chromium.org/382633002/diff/200001/ui/gfx/BUILD.gn#newcode316 ui/gfx/BUILD.gn:316: if(use_canvas_skia){ Nit: add spaces after if and before ...
6 years, 5 months ago (2014-07-18 20:19:10 UTC) #13
Nico
still lgtm https://codereview.chromium.org/382633002/diff/200001/ui/gfx/BUILD.gn File ui/gfx/BUILD.gn (right): https://codereview.chromium.org/382633002/diff/200001/ui/gfx/BUILD.gn#newcode316 ui/gfx/BUILD.gn:316: if(use_canvas_skia){ nit: add a space between if ...
6 years, 5 months ago (2014-07-18 20:19:57 UTC) #14
zhaoze.zhou
The CQ bit was checked by zhaoze.zhou@partner.samsung.com
6 years, 5 months ago (2014-07-18 20:25:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhaoze.zhou@partner.samsung.com/382633002/220001
6 years, 5 months ago (2014-07-18 20:26:25 UTC) #16
zhaoze.zhou
brettw@chromium.org: Please take a look.
6 years, 5 months ago (2014-07-18 20:35:39 UTC) #17
Nico
On 2014/07/18 20:35:39, zhaoze.zhou wrote: > mailto:brettw@chromium.org: Please take a look. brettw: is ui.gni intentionally ...
6 years, 5 months ago (2014-07-18 20:39:43 UTC) #18
zhaoze.zhou
On 2014/07/18 20:39:43, Nico (away) wrote: > On 2014/07/18 20:35:39, zhaoze.zhou wrote: > > mailto:brettw@chromium.org: ...
6 years, 5 months ago (2014-07-18 20:41:11 UTC) #19
Nico
On Fri, Jul 18, 2014 at 1:41 PM, <zhaoze.zhou@partner.samsung.com> wrote: > On 2014/07/18 20:39:43, Nico ...
6 years, 5 months ago (2014-07-18 20:42:52 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 23:22:06 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 23:25:07 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/81052)
6 years, 5 months ago (2014-07-18 23:25:08 UTC) #23
brettw
https://codereview.chromium.org/382633002/diff/220001/build/config/ui.gni File build/config/ui.gni (right): https://codereview.chromium.org/382633002/diff/220001/build/config/ui.gni#newcode50 build/config/ui.gni:50: if(is_android){ use_canvas_skia is only ever used once in the ...
6 years, 5 months ago (2014-07-23 20:50:33 UTC) #24
zhaoze.zhou
https://codereview.chromium.org/382633002/diff/220001/build/config/ui.gni File build/config/ui.gni (right): https://codereview.chromium.org/382633002/diff/220001/build/config/ui.gni#newcode50 build/config/ui.gni:50: if(is_android){ On 2014/07/23 20:50:32, brettw wrote: > use_canvas_skia is ...
6 years, 5 months ago (2014-07-24 14:28:45 UTC) #25
brettw
On 2014/07/24 14:28:45, zhaoze.zhou wrote: > https://codereview.chromium.org/382633002/diff/220001/build/config/ui.gni > File build/config/ui.gni (right): > > https://codereview.chromium.org/382633002/diff/220001/build/config/ui.gni#newcode50 > ...
6 years, 5 months ago (2014-07-24 16:35:23 UTC) #26
zhaoze.zhou
On 2014/07/24 16:35:23, brettw wrote: > On 2014/07/24 14:28:45, zhaoze.zhou wrote: > > https://codereview.chromium.org/382633002/diff/220001/build/config/ui.gni > ...
6 years, 5 months ago (2014-07-24 18:00:16 UTC) #27
zhaoze.zhou
On 2014/07/24 18:00:16, zhaoze.zhou wrote: > On 2014/07/24 16:35:23, brettw wrote: > > On 2014/07/24 ...
6 years, 5 months ago (2014-07-24 22:46:37 UTC) #28
brettw
lgtm
6 years, 5 months ago (2014-07-25 19:43:00 UTC) #29
zhaoze.zhou
The CQ bit was checked by zhaoze.zhou@partner.samsung.com
6 years, 5 months ago (2014-07-25 19:43:46 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhaoze.zhou@partner.samsung.com/382633002/310001
6 years, 5 months ago (2014-07-25 19:46:01 UTC) #31
zhaoze.zhou
The CQ bit was checked by zhaoze.zhou@partner.samsung.com
6 years, 5 months ago (2014-07-25 21:44:20 UTC) #32
zhaoze.zhou
The CQ bit was unchecked by zhaoze.zhou@partner.samsung.com
6 years, 5 months ago (2014-07-25 21:44:22 UTC) #33
zhaoze.zhou
The CQ bit was checked by zhaoze.zhou@partner.samsung.com
6 years, 5 months ago (2014-07-25 21:51:13 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhaoze.zhou@partner.samsung.com/382633002/330001
6 years, 5 months ago (2014-07-25 21:51:49 UTC) #35
commit-bot: I haz the power
6 years, 5 months ago (2014-07-26 00:10:07 UTC) #36
Message was sent while issue was closed.
Change committed as 285735

Powered by Google App Engine
This is Rietveld 408576698