Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 382623002: SkBitmap::Config is no more, use SkColorType (Closed)

Created:
6 years, 5 months ago by reed1
Modified:
6 years, 5 months ago
CC:
chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dcheng, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, miu+watch_chromium.org, nona+watch_chromium.org, penghuang+watch_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org, James Su, tfarina, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

SkBitmap::Config is no more, use SkColorType When this lands, we can remove SkBitmap::Config entirely from Skia TBR=kmadhusu@chromium.org mac_chromium_rel failure is unrelated to this CL (and passes locally) NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282431

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : missed some for chromeos and win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -28 lines) Patch
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/convert_web_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/thumbnails/content_analysis.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/thumbnails/content_analysis_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/fast_show_pickler.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_entry_screenshot_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/common_param_traits_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webclipboard_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/emf_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download
M skia/ext/image_operations.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/platform_canvas_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
reed1
my last SkBitmap::Config CL I promise. Need owners.
6 years, 5 months ago (2014-07-09 19:38:17 UTC) #1
reed1
this depends on https://codereview.chromium.org/379853002/ landing, hence the compile failures at the moment. Still valid to ...
6 years, 5 months ago (2014-07-09 20:14:24 UTC) #2
reed2
The CQ bit was checked by reed@chromium.org
6 years, 5 months ago (2014-07-10 00:06:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/382623002/1
6 years, 5 months ago (2014-07-10 00:10:33 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 00:10:34 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-10 00:10:35 UTC) #6
reed2
The CQ bit was checked by reed@chromium.org
6 years, 5 months ago (2014-07-10 00:12:27 UTC) #7
f(malita)
skia/ lgtm.
6 years, 5 months ago (2014-07-10 00:14:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/382623002/1
6 years, 5 months ago (2014-07-10 00:14:58 UTC) #9
reed2
build failures are because my blink change hasn't yet been pulled in via DEPS. Will ...
6 years, 5 months ago (2014-07-10 01:11:17 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 01:54:05 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 01:59:05 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/204510) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79010)
6 years, 5 months ago (2014-07-10 01:59:06 UTC) #13
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-10 11:20:35 UTC) #14
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-10 14:34:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/382623002/20001
6 years, 5 months ago (2014-07-10 14:35:59 UTC) #16
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-10 15:12:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/382623002/40001
6 years, 5 months ago (2014-07-10 15:12:12 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 17:32:37 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 20:13:53 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/47751)
6 years, 5 months ago (2014-07-10 20:13:54 UTC) #21
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-10 20:19:24 UTC) #22
reed1
The CQ bit was unchecked by reed@google.com
6 years, 5 months ago (2014-07-10 20:19:58 UTC) #23
reed1
The CQ bit was checked by reed@google.com
6 years, 5 months ago (2014-07-10 21:24:08 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/382623002/40001
6 years, 5 months ago (2014-07-10 21:25:10 UTC) #25
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 21:26:41 UTC) #26
Message was sent while issue was closed.
Change committed as 282431

Powered by Google App Engine
This is Rietveld 408576698