Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2114)

Unified Diff: sandbox/win/src/sync_dispatcher.cc

Issue 382613002: Fixes for re-enabling more MSVC level 4 warnings: sandbox/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sandbox/win/src/sync_dispatcher.cc
diff --git a/sandbox/win/src/sync_dispatcher.cc b/sandbox/win/src/sync_dispatcher.cc
index d4b36d5fc85000fc591f566229b25ad552d4222e..d9ebefc9ac3668e77153cc2664498884b70840c4 100644
--- a/sandbox/win/src/sync_dispatcher.cc
+++ b/sandbox/win/src/sync_dispatcher.cc
@@ -52,11 +52,9 @@ bool SyncDispatcher::CreateEvent(IPCInfo* ipc, base::string16* name,
EvalResult result = policy_base_->EvalPolicy(IPC_CREATEEVENT_TAG,
params.GetBase());
HANDLE handle = NULL;
- DWORD ret = SyncPolicy::CreateEventAction(result, *ipc->client_info, *name,
- event_type, initial_state,
- &handle);
// Return operation status on the IPC.
- ipc->return_info.nt_status = ret;
+ ipc->return_info.nt_status = SyncPolicy::CreateEventAction(
+ result, *ipc->client_info, *name, event_type, initial_state, &handle);
cpu_(ooo_6.6-7.5) 2014/07/10 00:49:34 don't you need 4 spaces before result?
Peter Kasting 2014/07/10 01:19:31 Yes. Oops.
ipc->return_info.handle = handle;
return true;
}
@@ -72,10 +70,9 @@ bool SyncDispatcher::OpenEvent(IPCInfo* ipc, base::string16* name,
EvalResult result = policy_base_->EvalPolicy(IPC_OPENEVENT_TAG,
params.GetBase());
HANDLE handle = NULL;
- DWORD ret = SyncPolicy::OpenEventAction(result, *ipc->client_info, *name,
- desired_access, &handle);
// Return operation status on the IPC.
- ipc->return_info.win32_result = ret;
+ ipc->return_info.nt_status = SyncPolicy::OpenEventAction(
+ result, *ipc->client_info, *name, desired_access, &handle);
ipc->return_info.handle = handle;
return true;
}

Powered by Google App Engine
This is Rietveld 408576698