Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 382603004: NaCl documentation: miscellaneous FAQ improvements (Closed)

Created:
6 years, 5 months ago by JF
Modified:
6 years, 5 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Project:
chromium
Visibility:
Public.

Description

NaCl documentation: miscellaneous FAQ improvements R= binji@chromium.org TEST= none BUG= none NOTRY=true (documentation only change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282137

Patch Set 1 #

Total comments: 12

Patch Set 2 : Address binji's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -180 lines) Patch
M native_client_sdk/doc_generated/_static/pygments.css View 1 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/faq.html View 1 11 chunks +98 lines, -99 lines 0 comments Download
M native_client_sdk/src/doc/faq.rst View 1 11 chunks +81 lines, -79 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
JF
6 years, 5 months ago (2014-07-09 21:36:31 UTC) #1
binji
lgtm https://codereview.chromium.org/382603004/diff/1/native_client_sdk/src/doc/faq.rst File native_client_sdk/src/doc/faq.rst (right): https://codereview.chromium.org/382603004/diff/1/native_client_sdk/src/doc/faq.rst#newcode73 native_client_sdk/src/doc/faq.rst:73: When should I use Portable Native Client instead ...
6 years, 5 months ago (2014-07-09 21:54:17 UTC) #2
JF
https://codereview.chromium.org/382603004/diff/1/native_client_sdk/src/doc/faq.rst File native_client_sdk/src/doc/faq.rst (right): https://codereview.chromium.org/382603004/diff/1/native_client_sdk/src/doc/faq.rst#newcode73 native_client_sdk/src/doc/faq.rst:73: When should I use Portable Native Client instead of ...
6 years, 5 months ago (2014-07-09 22:01:38 UTC) #3
JF
The CQ bit was checked by jfb@chromium.org
6 years, 5 months ago (2014-07-09 22:01:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfb@chromium.org/382603004/20001
6 years, 5 months ago (2014-07-09 22:02:15 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 22:05:00 UTC) #6
Message was sent while issue was closed.
Change committed as 282137

Powered by Google App Engine
This is Rietveld 408576698