Upload chrome_proxy to use results.AddValue(...)

tools/perf/metrics/chrome_proxy.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import logging
 import os
 
 from telemetry.page import page_measurement
 from metrics import network
+from telemetry.value import scalar
 
 
 class ChromeProxyMetricException(page_measurement.MeasurementFailure):
   pass
 
 
 CHROME_PROXY_VIA_HEADER = 'Chrome-Compression-Proxy'
 CHROME_PROXY_VIA_HEADER_DEPRECATED = '1.1 Chrome Compression Proxy'
 
 PROXY_SETTING_HTTPS = 'proxy.googlezip.net:443'
@@ skipping 95 matching lines @@
 
     super(ChromeProxyMetric, self).AddResults(tab, results)
     for resp in self.IterResponses(tab):
       if resp.response.served_from_cache:
         resources_from_cache += 1
       if resp.HasChromeProxyViaHeader():
         resources_via_proxy += 1
       else:
         resources_direct += 1
 
-    results.Add('resources_via_proxy', 'count', resources_via_proxy)
-    results.Add('resources_from_cache', 'count', resources_from_cache)
-    results.Add('resources_direct', 'count', resources_direct)
+    results.AddValue(scalar.ScalarValue(
+        results.current_page, 'resources_via_proxy', 'count',
+        resources_via_proxy))
+    results.AddValue(scalar.ScalarValue(
+        results.current_page, 'resources_from_cache', 'count',
+        resources_from_cache))
+    results.AddValue(scalar.ScalarValue(
+        results.current_page, 'resources_direct', 'count', resources_direct))
 
   def AddResultsForHeaderValidation(self, tab, results):
     via_count = 0
     bypass_count = 0
     for resp in self.IterResponses(tab):
       if resp.IsValidByViaHeader():
         via_count += 1
       elif tab and self.IsProxyBypassed(tab):
         logging.warning('Proxy bypassed for %s', resp.response.url)
         bypass_count += 1
       else:
         r = resp.response
         raise ChromeProxyMetricException, (
             '%s: Via header (%s) is not valid (refer=%s, status=%d)' % (
                 r.url, r.GetHeader('Via'), r.GetHeader('Referer'), r.status))
-    results.Add('checked_via_header', 'count', via_count)
-    results.Add('request_bypassed', 'count', bypass_count)
+    results.AddValue(scalar.ScalarValue(
+        results.current_page, 'checked_via_header', 'count', via_count))
+    results.AddValue(scalar.ScalarValue(
+        results.current_page, 'request_bypassed', 'count', bypass_count))
 
   def IsProxyBypassed(self, tab):
     """ Returns True if all configured proxies are bypassed."""
     info = GetProxyInfoFromNetworkInternals(tab)
     if not info['enabled']:
       raise ChromeProxyMetricException, (
           'Chrome proxy should be enabled. proxy info: %s' % info)
 
     bad_proxies = [str(p['proxy']) for p in info['badProxies']].sort()
     proxies = [self.effective_proxies['proxy'],
@@ skipping 46 matching lines @@
     if tab:
       info = GetProxyInfoFromNetworkInternals(tab)
       if not info['enabled']:
         raise ChromeProxyMetricException, (
             'Chrome proxy should be enabled. proxy info: %s' % info)
       self.VerifyBadProxies(
           info['badProxies'],
           [self.effective_proxies['proxy'],
            self.effective_proxies['fallback']])
 
-    results.Add('bypass', 'count', bypass_count)
+    results.AddValue(scalar.ScalarValue(
+        results.current_page, 'bypass', 'count', bypass_count))
 
   def AddResultsForSafebrowsing(self, tab, results):
     count = 0
     safebrowsing_count = 0
     for resp in self.IterResponses(tab):
       count += 1
       if resp.IsSafebrowsingResponse():
         safebrowsing_count += 1
       else:
         r = resp.response
         raise ChromeProxyMetricException, (
             '%s: Not a valid safe browsing response.\n'
             'Reponse: status=(%d, %s)\nHeaders:\n %s' % (
                 r.url, r.status, r.status_text, r.headers))
     if count == safebrowsing_count:
-      results.Add('safebrowsing', 'boolean', True)
+      results.AddValue(scalar.ScalarValue(
+          results.current_page, 'safebrowsing', 'boolean', True))
     else:
       raise ChromeProxyMetricException, (
           'Safebrowsing failed (count=%d, safebrowsing_count=%d)\n' % (
               count, safebrowsing_count))
 
   def AddResultsForHTTPFallback(
       self, tab, results, expected_proxies=None, expected_bad_proxies=None):
     info = GetProxyInfoFromNetworkInternals(tab)
     if not 'enabled' in info or not info['enabled']:
       raise ChromeProxyMetricException, (
@@ skipping 12 matching lines @@
           str(proxies), str(expected_proxies)))
 
     bad_proxies = []
     if 'badProxies' in info and info['badProxies']:
       bad_proxies = [p['proxy'] for p in info['badProxies']
                      if 'proxy' in p and p['proxy']]
     if bad_proxies != expected_bad_proxies:
       raise ChromeProxyMetricException, (
           'Wrong bad proxies (%s). Expect: "%s"' % (
           str(bad_proxies), str(expected_bad_proxies)))
-    results.Add('http_fallback', 'boolean', True)
+    results.AddValue(scalar.ScalarValue(
+        results.current_page, 'http_fallback', 'boolean', True))