Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 382563002: In iossim, use default home directory if no -u override is given. (Closed)

Created:
6 years, 5 months ago by lliabraa
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

In iossim, use default home directory if no -u override is given. With Xcode 6, the home directory of the iOS Simulator and iossim processes must match so that the iOS Simulator can find the SimDevice object created by iossim. Since the existing behavior of iossim is to create a new, random, home directory on each run (if no -u value is specified on the command line), the home directories will be mismatched if iossim is launched multiple times without killing the iOS Simulator in between runs. The fix here is to only override the home directory in iossim if -u is specified. Since this will often reuse the default SimDeviceSet (at ~/Library/Developer/CoreSimulator/Devices), functionality is also changed to reuse an existing SimDevice if possible (though iossim will create a SimDevice if necessary). BUG=None TBR=rohitrao Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282139

Patch Set 1 #

Patch Set 2 : whitespace fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -26 lines) Patch
M testing/iossim/iossim.mm View 1 3 chunks +43 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
lliabraa
6 years, 5 months ago (2014-07-09 15:56:14 UTC) #1
lliabraa
6 years, 5 months ago (2014-07-09 15:57:00 UTC) #2
justincohen
n.b. lgtm
6 years, 5 months ago (2014-07-09 17:37:36 UTC) #3
lliabraa
The CQ bit was checked by lliabraa@chromium.org
6 years, 5 months ago (2014-07-09 17:42:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/382563002/20001
6 years, 5 months ago (2014-07-09 17:44:50 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 22:12:16 UTC) #6
Message was sent while issue was closed.
Change committed as 282139

Powered by Google App Engine
This is Rietveld 408576698