Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 382553004: Mojo: Mojom: Add AST types for imports and import lists. (Closed)

Created:
6 years, 5 months ago by viettrungluu
Modified:
6 years, 5 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Mojom: Add AST types for imports and import lists. R=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282184

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -12 lines) Patch
M mojo/public/tools/bindings/pylib/mojom/parse/ast.py View 1 chunk +18 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 1 chunk +20 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/378383002/.)
6 years, 5 months ago (2014-07-09 18:28:17 UTC) #1
DaveMoore
lgtm
6 years, 5 months ago (2014-07-09 21:46:47 UTC) #2
viettrungluu
6 years, 5 months ago (2014-07-10 00:08:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r282184 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698