Issue 382523002: Revert "Remove ability for Release code to call getRefCnt() or getWeakRefCnt()."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 382523002: Revert "Remove ability for Release code to call getRefCnt() or getWeakRefCnt()." (Closed)

Created:
6 years, 5 months ago by mtklein_C

Modified:
6 years, 5 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert "Remove ability for Release code to call getRefCnt() or getWeakRefCnt()." This reverts commit 4ae94ffce5ecf1b71cb5e295b68bf4ec9e697443. BUG=skia: Committed: https://skia.googlesource.com/skia/+/874a62a

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -117 lines)			Patch
M	gyp/tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/tools.gyp	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	include/core/SkImageFilter.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkRefCnt.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	include/core/SkWeakRefCnt.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/core/SkImageFilter.cpp	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	tests/ClipCacheTest.cpp	View	4 chunks	+5 lines, -6 lines	0 comments	Download
M	tests/ImageFilterTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/MetaDataTest.cpp	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	tests/RefCntTest.cpp	View	5 chunks	+5 lines, -6 lines	0 comments	Download
M	tests/RefDictTest.cpp	View	2 chunks	+15 lines, -16 lines	0 comments	Download
M	tests/SurfaceTest.cpp	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	tests/UtilsTest.cpp	View	5 chunks	+25 lines, -26 lines	0 comments	Download
D	tools/RefCntIs.h	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	tools/RefCntIs.cpp	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	tools/tsan.supp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r874a62a.

Expand Messages | Collapse Messages