Issue 382493003: PasswordFormManager::best_matches should return a const ref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 382493003: PasswordFormManager::best_matches should return a const ref (Closed)

Created:
6 years, 5 months ago by vabr (Chromium)

Modified:
6 years, 5 months ago

Reviewers:
engedy, Mike West

CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

PasswordFormManager::best_matches should return a const ref Currently, it returns 'const PasswordFormMap'. While returning a value, marking it const does not make much sense (it's a copy anyway). So it should be either 'const PasswordFormMap&' or just 'PasswordFormMap'. The only place this call is used at makes a copy of the result anyway, so I chose the former. That also seems to be a more versatile choice -- if somebody needs just a read-only copy in the future, returning by value would result in an unnecessary copy. BUG=261628 R=mkwst@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282018