tools/testrunner/local/progress.py - Issue 382443004: Fix test driver output for passes in predictable mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testrunner/local/progress.py

Issue 382443004: Fix test driver output for passes in predictable mode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testrunner/local/progress.py

diff --git a/tools/testrunner/local/progress.py b/tools/testrunner/local/progress.py

index 2c9f650013eb5daacb75af09985009a960545806..8caa58c44ccb4864eaccfd804151961a4aed646c 100644

--- a/tools/testrunner/local/progress.py

+++ b/tools/testrunner/local/progress.py

@@ -318,9 +318,9 @@ class JsonTestProgressIndicator(ProgressIndicator):

def HasRun(self, test, has_unexpected_output):

self.progress_indicator.HasRun(test, has_unexpected_output)

- if test.run == 1 and not has_unexpected_output:

- # Omit tests that pass on the first run, but collect output of tests

- # that pass when rerun.

+ if not has_unexpected_output:

+ # Omit tests that run as expected. Passing tests of reruns after failures

+ # will have unexpected_output to be reported here has well.

return

self.results.append({

« no previous file with comments | « tools/testrunner/local/execution.py ('k') | no next file » | no next file with comments »