tools/testrunner/local/execution.py - Issue 382443004: Fix test driver output for passes in predictable mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testrunner/local/execution.py

Issue 382443004: Fix test driver output for passes in predictable mode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testrunner/local/execution.py

diff --git a/tools/testrunner/local/execution.py b/tools/testrunner/local/execution.py

index d2d086c111e3c086054d7a31f97ce97a980bdd32..a339eeb85d905402607a7e50f2795f192a91ba3f 100644

--- a/tools/testrunner/local/execution.py

+++ b/tools/testrunner/local/execution.py

@@ -138,7 +138,10 @@ class Runner(object):

else:

self.succeeded += 1

self.remaining -= 1

- self.indicator.HasRun(test, has_unexpected_output)

+ # For the indicator, everything that happens after the first run is treated

+ # as unexpected even if it flakily passes in order to include it in the

+ # output.

+ self.indicator.HasRun(test, has_unexpected_output or test.run > 1)

if has_unexpected_output:

# Rerun test failures after the indicator has processed the results.

self._MaybeRerun(pool, test)

« no previous file with comments | « no previous file | tools/testrunner/local/progress.py » ('j') | no next file with comments »