Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 382443004: Fix test driver output for passes in predictable mode. (Closed)

Created:
6 years, 5 months ago by Michael Achenbach
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix test driver output for passes in predictable mode. Passes in predictable mode were wrongly reported as failures by the json progress indicator. This moves control about what is reported completely to execution.py. BUG=391747 LOG=n R=ishell@chromium.org, jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M tools/testrunner/local/execution.py View 1 chunk +4 lines, -1 line 0 comments Download
M tools/testrunner/local/progress.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
6 years, 5 months ago (2014-07-09 11:17:16 UTC) #1
Jakob Kummerow
lgtm
6 years, 5 months ago (2014-07-09 11:21:32 UTC) #2
Igor Sheludko
lgtm
6 years, 5 months ago (2014-07-09 11:28:22 UTC) #3
Michael Achenbach
6 years, 5 months ago (2014-07-09 11:37:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r22299 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698