Issue 382443002: maximumAge and timeout should be used after initialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 382443002: maximumAge and timeout should be used after initialization. (Closed)

Created:
6 years, 5 months ago by kihong

Modified:
6 years, 5 months ago

Reviewers:
haraken, Michael van Ouwerkerk

CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, timvolodine

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

maximumAge and timeout should be used after initialization. Local variables(maximumAge and timeout) in PositionOptions constructor could be used without initializing, if "options.get()" returns false. BUG=390314 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177789

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -16 lines)			Patch
	M	Source/modules/geolocation/PositionOptions.cpp	View		1 chunk	+21 lines, -16 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/382443002/1

6 years, 5 months ago (2014-07-10 01:05:08 UTC) #4

Message was sent while issue was closed.

Change committed as 177789

Expand Messages | Collapse Messages